Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Rebase please work Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
diff --git a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
index cc8257a2eb93d5c98caafedce876f1ba607f4770..e1be9cb55cd985837a4a6a85c187368a6579e654 100644
--- a/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
+++ b/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
@@ -127,17 +127,17 @@ InterpolationValue CSSVisibilityInterpolationType::maybeConvertInherit(const Sty
InterpolationValue CSSVisibilityInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState& state, ConversionCheckers& conversionCheckers) const
{
- if (!value.isPrimitiveValue())
+ if (!value.isIdentifierValue())
return nullptr;
- const CSSPrimitiveValue& primitiveValue = toCSSPrimitiveValue(value);
- CSSValueID keyword = primitiveValue.getValueID();
+ const CSSIdentifierValue& identifierValue = toCSSIdentifierValue(value);
+ CSSValueID keyword = identifierValue.getValueID();
switch (keyword) {
case CSSValueHidden:
case CSSValueVisible:
case CSSValueCollapse:
- return createVisibilityValue(primitiveValue.convertTo<EVisibility>());
+ return createVisibilityValue(identifierValue.convertTo<EVisibility>());
default:
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698