third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

index e23a4de1cbfe72ba3eb01fdcd9d319a5b9596c2b..f641632c80540829590bb95d7ecee32c724892e1 100644

--- a/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp

@@ -82,7 +82,7 @@ void TransformBuilder::createTransformOperations(const CSSValue& inValue, const

{

ASSERT(!outOperations.size());

if (!inValue.isValueList()) {

- ASSERT(inValue.isPrimitiveValue() && toCSSPrimitiveValue(inValue).getValueID() == CSSValueNone);

+ DCHECK_EQ(toCSSIdentifierValue(inValue).getValueID(), CSSValueNone);

return;

}