third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/CSSValue.h ('K') | « third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

index ade326092eb9962e4192c6c27797ed21162f9d0c..abe552c9e7b841c6c6ff3153bf4ad9ec73e3057f 100644

--- a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -120,8 +120,8 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt

{

FilterOperations operations;

- if (inValue.isPrimitiveValue()) {

- ASSERT(toCSSPrimitiveValue(inValue).getValueID() == CSSValueNone);

+ if (inValue.isIdentifierValue()) {

+ DCHECK_EQ(toCSSIdentifierValue(inValue).getValueID(), CSSValueNone);

return operations;

}