third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/SizeInterpolationFunctions.cpp ('k') | third_party/WebKit/Source/core/animation/animatable/AnimatableUnknownTest.cpp » ('j') | third_party/WebKit/Source/core/css/CSSPrimitiveValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h

diff --git a/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h b/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h

index 03e673d42a57f7d4e4fb76ee149c14f2ab425682..def3b105b12bccfc59334371f0201ce271041ec8 100644

--- a/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h

+++ b/third_party/WebKit/Source/core/animation/animatable/AnimatableUnknown.h

@@ -33,7 +33,7 @@

#include "core/CSSValueKeywords.h"

#include "core/animation/animatable/AnimatableValue.h"

-#include "core/css/CSSPrimitiveValue.h"

+#include "core/css/CSSIdentifierValue.h"

namespace blink {

@@ -47,11 +47,11 @@ public:

}

static PassRefPtr<AnimatableUnknown> create(CSSValueID value)

{

- return adoptRef(new AnimatableUnknown(CSSPrimitiveValue::createIdentifier(value)));

+ return adoptRef(new AnimatableUnknown(CSSIdentifierValue::create(value)));

}

CSSValue* toCSSValue() const { return m_value; }

- CSSValueID toCSSValueID() const { return toCSSPrimitiveValue(m_value.get())->getValueID(); }

+ CSSValueID toCSSValueID() const { return toCSSIdentifierValue(m_value.get())->getValueID(); }

protected:

PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue* value, double fraction) const override