third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp ('k') | third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp » ('j') | third_party/WebKit/Source/core/css/CSSPrimitiveValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp

diff --git a/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp b/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp

index f8dd47cc825149ff02b018ec19e8ddfd527529b3..35e27294331e20174b1f1a8dd9aaba7b14273f19 100644

--- a/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp

+++ b/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp

@@ -7,6 +7,7 @@

#include "core/animation/ListInterpolationFunctions.h"

#include "core/animation/ShadowInterpolationFunctions.h"

#include "core/animation/ShadowListPropertyFunctions.h"

+#include "core/css/CSSIdentifierValue.h"

#include "core/css/CSSValueList.h"

#include "core/css/resolver/StyleBuilder.h"

#include "core/css/resolver/StyleResolverState.h"

@@ -79,7 +80,7 @@ InterpolationValue CSSShadowListInterpolationType::maybeConvertInherit(const Sty

InterpolationValue CSSShadowListInterpolationType::maybeConvertValue(const CSSValue& value, const StyleResolverState&, ConversionCheckers&) const

{

- if (value.isPrimitiveValue() && toCSSPrimitiveValue(value).getValueID() == CSSValueNone)

+ if (value.isIdentifierValue() && toCSSIdentifierValue(value).getValueID() == CSSValueNone)

return createNeutralValue();

if (!value.isBaseValueList())