third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp - Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp » ('j') | third_party/WebKit/Source/core/css/CSSPrimitiveValue.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp

diff --git a/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp b/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp

index d06d1b23fec0e99bc113722fa0cb4a27afebdd9f..7993364d8fa6f97527186a14d4b5c7d9e13d3cc1 100644

--- a/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp

+++ b/third_party/WebKit/Source/core/animation/BasicShapeInterpolationFunctions.cpp

@@ -103,9 +103,9 @@ BasicShapeCenterCoordinate createCoordinate(const InterpolableValue& interpolabl

LengthInterpolationFunctions::createLength(interpolableValue, nullptr, conversionData, ValueRangeAll));

}

-std::unique_ptr<InterpolableValue> convertCSSRadius(const CSSPrimitiveValue* radius)

+std::unique_ptr<InterpolableValue> convertCSSRadius(const CSSValue* radius)

{

- if (!radius || radius->isValueID())

+ if (!radius || radius->isIdentifierValue())

return nullptr;

return unwrap(LengthInterpolationFunctions::maybeConvertCSSValue(*radius));

}