Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

third_party/WebKit/Source/core/css/CSSIdentifierValue.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CSSIdentifierValue_h
+#define CSSIdentifierValue_h
+
+#include "core/CSSValueKeywords.h"
+#include "core/css/CSSValue.h"
+#include "wtf/TypeTraits.h"
+
+namespace blink {
+
+class CORE_EXPORT CSSIdentifierValue : public CSSValue {
+public:
+    // TODO(sashab): Rename this to just create().

[rjwright, 2016/09/22 06:12:50]

How come you don't do this in this patch? Does it make it too big?

[sashab, 2016/09/23 01:01:10]

I have a style where I like to limit patches to just a single change. It helps
prevent rebasing problems and keeps the CL description meaningful. Also, this
patch is sort of 'the hard part', whereas a rename is relatively easy - if I
don't get around to it, someone else can easily do it. But I want to get the
hard part out of the way :)

[Timothy Loh, 2016/09/23 04:06:14]

At least for this one you're already renaming from
CSSPrimitiveValue::createIdentifier to CSSIdentifierValue::createIdentifier, why
not just rename it to CSSIdentifierValue::create straight away instead of
touching all the lines twice? The other TODOs I'm fine with.

+    static CSSIdentifierValue* createIdentifier(CSSValueID);
+
+    // TODO(sashab): Rename this to createFromPlatformValue().

[rjwright, 2016/09/22 06:12:50]

Why wait?

[sashab, 2016/09/23 01:01:10]

Same argument as above.

+    template<typename T> static CSSIdentifierValue* create(T value)
+    {
+        static_assert(!std::is_same<T, CSSValueID>::value, "Do not call create() with a CSSValueID; call createIdentifier() instead");
+        return new CSSIdentifierValue(value);
+    }
+
+    static CSSIdentifierValue* create(const Length& value)
+    {
+        return new CSSIdentifierValue(value);
+    }
+
+    CSSValueID getValueID() const { return m_valueID; }
+
+    String customCSSText() const;
+
+    bool equals(const CSSIdentifierValue& other) const
+    {
+        return m_valueID == other.m_valueID;
+    }
+
+    template<typename T> inline T convertTo() const; // Defined in CSSPrimitiveValueMappings.h
+
+    DECLARE_TRACE_AFTER_DISPATCH();
+
+private:
+    explicit CSSIdentifierValue(CSSValueID);
+
+    // TODO(sashab): Remove this function, and update mapping methods to specialize
+    // the create() method instead.
+    template<typename T> CSSIdentifierValue(T); // Defined in CSSPrimitiveValueMappings.h
+
+    CSSIdentifierValue(const Length&);
+
+    CSSValueID m_valueID;
+};
+
+DEFINE_CSS_VALUE_TYPE_CASTS(CSSIdentifierValue, isIdentifierValue());
+
+} // namespace blink
+
+#endif // CSSIdentifierValue_h