Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 2346193002: Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue (Closed)
Patch Set: Rebase please work Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 feature = UseCounter::CSSFilterDropShadow; 113 feature = UseCounter::CSSFilterDropShadow;
114 break; 114 break;
115 }; 115 };
116 UseCounter::count(document, feature); 116 UseCounter::count(document, feature);
117 } 117 }
118 118
119 FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt ate& state, const CSSValue& inValue) 119 FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt ate& state, const CSSValue& inValue)
120 { 120 {
121 FilterOperations operations; 121 FilterOperations operations;
122 122
123 if (inValue.isPrimitiveValue()) { 123 if (inValue.isIdentifierValue()) {
124 ASSERT(toCSSPrimitiveValue(inValue).getValueID() == CSSValueNone); 124 DCHECK_EQ(toCSSIdentifierValue(inValue).getValueID(), CSSValueNone);
125 return operations; 125 return operations;
126 } 126 }
127 127
128 const CSSToLengthConversionData& conversionData = state.cssToLengthConversio nData(); 128 const CSSToLengthConversionData& conversionData = state.cssToLengthConversio nData();
129 for (auto& currValue : toCSSValueList(inValue)) { 129 for (auto& currValue : toCSSValueList(inValue)) {
130 if (currValue->isURIValue()) { 130 if (currValue->isURIValue()) {
131 countFilterUse(FilterOperation::REFERENCE, state.document()); 131 countFilterUse(FilterOperation::REFERENCE, state.document());
132 132
133 const CSSURIValue& urlValue = toCSSURIValue(*currValue); 133 const CSSURIValue& urlValue = toCSSURIValue(*currValue);
134 SVGURLReferenceResolver resolver(urlValue.value(), state.document()) ; 134 SVGURLReferenceResolver resolver(urlValue.value(), state.document()) ;
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 default: 206 default:
207 ASSERT_NOT_REACHED(); 207 ASSERT_NOT_REACHED();
208 break; 208 break;
209 } 209 }
210 } 210 }
211 211
212 return operations; 212 return operations;
213 } 213 }
214 214
215 } // namespace blink 215 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698