Split CSSPrimitiveValue into CSSPrimitiveValue and CSSIdentifierValue

third_party/WebKit/Source/core/css/CSSValue.h

 /*
  * (C) 1999-2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #ifndef CSSValue_h
 #define CSSValue_h
 
 #include "core/CoreExport.h"
 #include "platform/heap/Handle.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
+class Length;
+
+// CSSValue stores parsed representations of values on the RHS of a CSS declaration.
+// For example:
+//     width: 30px;
+// Would create a CSSValue to represent '30px'.
+//
+// CSSValues are property-independent; they can be created for any property, but

[Timothy Loh, 2016/09/30 05:44:35]

This sounds contradictory (and is probably wrong because
CSSCustomPropertyDeclaration objects store property information). Can we omit
the comments here for this patch since yuo want to get this in today and
bikeshed it later?

[sashab, 2016/09/30 06:45:48]

Done, removed entire header comment in this file.

+// not all CSSValues are valid for all properties.
+//
+// All CSSValues should be immutable.
 class CORE_EXPORT CSSValue : public GarbageCollectedFinalized<CSSValue> {
 public:
     // Override operator new to allocate CSSValue subtype objects onto
     // a dedicated heap.
     GC_PLUGIN_IGNORE("crbug.com/443854")
     void* operator new(size_t size)
     {
         return allocateObject(size, false);
     }
     static void* allocateObject(size_t size, bool isEager)
     {
         ThreadState* state = ThreadStateFor<ThreadingTrait<CSSValue>::Affinity>::state();
         const char typeName[] = "blink::CSSValue";
         return ThreadHeap::allocateOnArenaIndex(state, size, isEager ? BlinkGC::EagerSweepArenaIndex : BlinkGC::CSSValueArenaIndex, GCInfoTrait<CSSValue>::index(), typeName);
     }
 
+    // TODO(sashab): Remove this method and move logic to the caller.
+    static CSSValue* create(const Length& value, float zoom);
+
     String cssText() const;
 
     bool isPrimitiveValue() const { return m_classType == PrimitiveClass; }
+    bool isIdentifierValue() const { return m_classType == IdentifierClass; }
     bool isValuePair() const { return m_classType == ValuePairClass; }
     bool isValueList() const { return m_classType >= ValueListClass; }
 
     bool isBaseValueList() const { return m_classType == ValueListClass; }
 
     bool isBasicShapeValue() const { return m_classType >= BasicShapeCircleClass && m_classType <= BasicShapeInsetClass; }
     bool isBasicShapeCircleValue() const { return m_classType == BasicShapeCircleClass; }
     bool isBasicShapeEllipseValue() const { return m_classType == BasicShapeEllipseClass; }
     bool isBasicShapePolygonValue() const { return m_classType == BasicShapePolygonClass; }
     bool isBasicShapeInsetValue() const { return m_classType == BasicShapeInsetClass; }
@@ skipping 48 matching lines @@
     // ~CSSValue should be public, because non-public ~CSSValue causes C2248
     // error: 'blink::CSSValue::~CSSValue' : cannot access protected member
     // declared in class 'blink::CSSValue' when compiling
     // 'source\wtf\refcounted.h' by using msvc.
     ~CSSValue() { }
 
 protected:
     static const size_t ClassTypeBits = 6;
     enum ClassType {
         PrimitiveClass,
+        IdentifierClass,
         ColorClass,
         CounterClass,
         QuadClass,
         CustomIdentClass,
         StringClass,
         URIClass,
         ValuePairClass,
 
         // Basic shape classes.
         // TODO(sashab): Represent these as a single subclass, BasicShapeClass.
@@ skipping 126 matching lines @@
         return false;
     return first->equals(*second);
 }
 
 #define DEFINE_CSS_VALUE_TYPE_CASTS(thisType, predicate) \
     DEFINE_TYPE_CASTS(thisType, CSSValue, value, value->predicate, value.predicate)
 
 } // namespace blink
 
 #endif // CSSValue_h