Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2346183002: Ensure container is attached to Window (Closed)

Created:
4 years, 3 months ago by Jinsuk Kim
Modified:
4 years, 3 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure container is attached to Window Ensure container is attached to Window when acquiring an anchor view. BUG=646320 Committed: https://crrev.com/5e095b790756aaa59dd8d5630e7dd13f5866e669 Cr-Commit-Position: refs/heads/master@{#419895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Jinsuk Kim
4 years, 3 months ago (2016-09-19 00:31:34 UTC) #4
Ted C
lgtm FWIW, I was not able to repro the bug as easily as shown in ...
4 years, 3 months ago (2016-09-20 04:08:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2346183002/1
4 years, 3 months ago (2016-09-20 22:29:58 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 23:30:06 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 23:33:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e095b790756aaa59dd8d5630e7dd13f5866e669
Cr-Commit-Position: refs/heads/master@{#419895}

Powered by Google App Engine
This is Rietveld 408576698