Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2346163005: Remove package root target and support scripts (Closed)

Created:
4 years, 3 months ago by Bill Hesse
Modified:
4 years, 3 months ago
Reviewers:
zra, kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org, zra, Cutch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove package root target and support scripts BUG=https://github.com/dart-lang/sdk/issues/23565 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/0695b1db3aeeb67e98c5798c5446864f44fccfac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -296 lines) Patch
M dart.gyp View 6 chunks +0 lines, -12 lines 0 comments Download
D pkg/BUILD.gn View 1 chunk +0 lines, -35 lines 0 comments Download
D pkg/pkg.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/bots/run_android_tests.sh View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dartium/build.py View 1 chunk +0 lines, -1 line 0 comments Download
D tools/list_pkg_directories.py View 1 chunk +0 lines, -39 lines 0 comments Download
D tools/make_links.py View 1 chunk +0 lines, -161 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Bill Hesse
4 years, 3 months ago (2016-09-20 11:09:13 UTC) #2
kustermann
lgtm
4 years, 3 months ago (2016-09-20 11:18:09 UTC) #3
Bill Hesse
Committed patchset #1 (id:1) manually as 0695b1db3aeeb67e98c5798c5446864f44fccfac (presubmit successful).
4 years, 3 months ago (2016-09-20 11:32:56 UTC) #5
zra
4 years, 3 months ago (2016-09-20 14:30:47 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698