Deflake virtual/threaded/animations/{opacity,transform}-responsive-neutral-keyframe.html

Deflake virtual/threaded/animations/{opacity,transform}-responsive-neutral-keyframe.html

This change uses the ready promise on a composited transform animation
to determine whether the compositor has synchronised with the main thread.

This is the same as https://codereview.chromium.org/2309413002 but for
similar tests.

BUG=647776
Committed: https://crrev.com/330ee75cd45ae63ce99b0802e41355e97bde5842
Cr-Commit-Position: refs/heads/master@{#419415}

[alancutter (OOO until 2018), 2016-09-19 01:05:06]

alancutter@chromium.org changed reviewers:
+ ericwilligers@chromium.org

[alancutter (OOO until 2018), 2016-09-19 01:05:13]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 01:05:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 02:09:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 02:09:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eric Willigers, 2016-09-19 02:39:27]

I like the opacity test change, but I don't understand the transform test. Why
does the -expected.html have an animation?

[alancutter (OOO until 2018), 2016-09-19 04:16:36]

On 2016/09/19 at 02:39:27, ericwilligers wrote:
> I like the opacity test change, but I don't understand the transform test. Why
does the -expected.html have an animation?

Not sure. Simplified test and expectations.

[alancutter (OOO until 2018), 2016-09-19 04:17:09]

The CQ bit was checked by alancutter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 04:17:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-09-19 04:50:56]

https://codereview.chromium.org/2346163003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/transform-responsive-neutral-keyframe.html
(right):

https://codereview.chromium.org/2346163003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/transform-responsive-neutral-keyframe.html:18:
to { transform: translateX(50px); }
Can this be completely different, like translateX(200px);

[commit-bot: I haz the power, 2016-09-19 05:02:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 05:02:53]

Dry run: This issue passed the CQ dry run.

[alancutter (OOO until 2018), 2016-09-19 05:14:00]

https://codereview.chromium.org/2346163003/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/animations/transform-responsive-neutral-keyframe.html
(right):

https://codereview.chromium.org/2346163003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/animations/transform-responsive-neutral-keyframe.html:18:
to { transform: translateX(50px); }
On 2016/09/19 at 04:50:55, Eric Willigers wrote:
> Can this be completely different, like translateX(200px);

Making it different just increases the chance of this test being flaky, I don't
see any gain in doing so.

[Eric Willigers, 2016-09-19 05:53:48]

lgtm

[alancutter (OOO until 2018), 2016-09-19 05:56:36]

The CQ bit was checked by alancutter@chromium.org

[commit-bot: I haz the power, 2016-09-19 05:56:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 06:01:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-19 06:03:45]

Description was changed from

==========
Deflake
virtual/threaded/animations/{opacity,transform}-responsive-neutral-keyframe.html

This change uses the ready promise on a composited transform animation
to determine whether the compositor has synchronised with the main thread.

This is the same as https://codereview.chromium.org/2309413002 but for
similar tests.

BUG=647776
==========

to

==========
Deflake
virtual/threaded/animations/{opacity,transform}-responsive-neutral-keyframe.html

This change uses the ready promise on a composited transform animation
to determine whether the compositor has synchronised with the main thread.

This is the same as https://codereview.chromium.org/2309413002 but for
similar tests.

BUG=647776

Committed: https://crrev.com/330ee75cd45ae63ce99b0802e41355e97bde5842
Cr-Commit-Position: refs/heads/master@{#419415}
==========

[commit-bot: I haz the power, 2016-09-19 06:03:46]

Patchset 2 (id:??) landed as
https://crrev.com/330ee75cd45ae63ce99b0802e41355e97bde5842
Cr-Commit-Position: refs/heads/master@{#419415}