Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2346143003: fix #27363, support `@checked` on fields (Closed)

Created:
4 years, 3 months ago by Jennifer Messerly
Modified:
4 years, 3 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27363, support `@checked` on fields Just needed to have the synthetic setter param look for metadata on the field. R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/70f6e16c97dc0f48d29deefdd7960cf3172b31a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/checker_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jennifer Messerly
4 years, 3 months ago (2016-09-17 00:42:07 UTC) #4
Leaf
lgtm When we support @virtual, we should add tests for the inherited case.
4 years, 3 months ago (2016-09-17 01:14:28 UTC) #5
Jennifer Messerly
Committed patchset #1 (id:1) manually as 70f6e16c97dc0f48d29deefdd7960cf3172b31a2 (presubmit successful).
4 years, 3 months ago (2016-09-17 01:20:32 UTC) #7
scheglov
4 years, 3 months ago (2016-09-17 01:56:10 UTC) #8
Message was sent while issue was closed.
LGTM
Thanks!

Powered by Google App Engine
This is Rietveld 408576698