Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23461039: add context save for GenerateFastApiCall (Closed)

Created:
7 years, 3 months ago by dcarney
Modified:
7 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

add context save for GenerateFastApiCall R=mstarzinger@chromium.org BUG=

Patch Set 1 : #

Total comments: 3

Patch Set 2 : x64 should be good #

Patch Set 3 : ia32 #

Patch Set 4 : arm #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -137 lines) Patch
M include/v8.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/arguments.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 5 chunks +27 lines, -14 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 12 chunks +43 lines, -23 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 6 chunks +24 lines, -13 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 11 chunks +41 lines, -25 lines 1 comment Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 5 chunks +24 lines, -13 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 11 chunks +50 lines, -36 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dcarney
ptal this is in no way a hack!
7 years, 3 months ago (2013-09-10 07:51:47 UTC) #1
dcarney
okay, ptal for real now
7 years, 3 months ago (2013-09-10 11:04:33 UTC) #2
Michael Starzinger
https://codereview.chromium.org/23461039/diff/7001/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): https://codereview.chromium.org/23461039/diff/7001/src/x64/macro-assembler-x64.cc#newcode824 src/x64/macro-assembler-x64.cc:824: bool restore_context = restore_context_offset != 0; Hmpf! The context ...
7 years, 3 months ago (2013-09-12 18:38:51 UTC) #3
dcarney
okay, this should be good, ptal
7 years, 3 months ago (2013-09-16 12:23:24 UTC) #4
Michael Starzinger
LGTM. https://codereview.chromium.org/23461039/diff/18001/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): https://codereview.chromium.org/23461039/diff/18001/src/ia32/stub-cache-ia32.cc#newcode544 src/ia32/stub-cache-ia32.cc:544: ebp, (kFastApiCallArguments + 1) * kPointerSize); nit: Indentation ...
7 years, 3 months ago (2013-09-16 15:08:50 UTC) #5
dcarney
7 years, 3 months ago (2013-09-17 07:23:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r16744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698