Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 23461032: Linux Sandbox: add RawSandboxDie() (Closed)

Created:
7 years, 3 months ago by jln (very slow on Chromium)
Modified:
7 years, 3 months ago
Reviewers:
Markus (顧孟勤)
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Linux Sandbox: add RawSandboxDie() Add an async signal safe version of SANDBOX_DIE(). BUG=277240 R=markus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221558

Patch Set 1 #

Patch Set 2 : Support NULL #

Patch Set 3 : __attribute__ ((noinline)) for SigSys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M sandbox/linux/seccomp-bpf/die.h View 2 chunks +7 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/die.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jln (very slow on Chromium)
Markus, PTAL!
7 years, 3 months ago (2013-09-05 23:44:37 UTC) #1
Markus (顧孟勤)
lgtm It would be nice to have a unit test that at least triggered execution ...
7 years, 3 months ago (2013-09-06 00:08:11 UTC) #2
jln (very slow on Chromium)
7 years, 3 months ago (2013-09-06 01:28:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r221558 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698