[Android WebView] Set WebView font renderer preferences

android_webview/native/aw_contents.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/aw_contents.h"
 
 #include "android_webview/browser/aw_browser_context.h"
 #include "android_webview/browser/aw_browser_main_parts.h"
 #include "android_webview/browser/gpu_memory_buffer_factory_impl.h"
 #include "android_webview/browser/in_process_view_renderer.h"
@@ skipping 129 matching lines @@
   web_contents_->SetUserData(kAwContentsUserDataKey,
                              new AwContentsUserData(this));
   render_view_host_ext_.reset(
       new AwRenderViewHostExt(this, web_contents_.get()));
 
   AwAutofillManagerDelegate* autofill_manager_delegate =
       AwAutofillManagerDelegate::FromWebContents(web_contents_.get());
   if (autofill_manager_delegate)
     InitAutofillIfNecessary(autofill_manager_delegate->GetSaveFormData());
 
-  web_contents_->GetMutableRendererPrefs()->tap_multiple_targets_strategy =
-      content::TAP_MULTIPLE_TARGETS_STRATEGY_NONE;
+  SetAndroidWebViewRendererPrefs();
 }
 
 void AwContents::SetJavaPeers(JNIEnv* env,
                               jobject obj,
                               jobject aw_contents,
                               jobject web_contents_delegate,
                               jobject contents_client_bridge,
                               jobject io_thread_client,
                               jobject intercept_navigation_delegate) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ skipping 45 matching lines @@
   AwBrowserContext::FromWebContents(web_contents)->
       CreateUserPrefServiceIfNecessary();
   AwAutofillManagerDelegate::CreateForWebContents(web_contents);
   AutofillDriverImpl::CreateForWebContentsAndDelegate(
       web_contents,
       AwAutofillManagerDelegate::FromWebContents(web_contents),
       l10n_util::GetDefaultLocale(),
       AutofillManager::DISABLE_AUTOFILL_DOWNLOAD_MANAGER);
 }
 
+void AwContents::SetAndroidWebViewRendererPrefs() {
+  content::RendererPreferences* prefs =
+      web_contents_->GetMutableRendererPrefs();
+  prefs->tap_multiple_targets_strategy =
+      content::TAP_MULTIPLE_TARGETS_STRATEGY_NONE;
+  prefs->hinting = content::RENDERER_PREFERENCES_HINTING_SLIGHT;
+  web_contents_->GetRenderViewHost()->SyncRendererPrefs();

[boliu, 2013/08/29 16:48:31]

Hmm, I think we do have a RVH at this point, but not RV, and this just becomes a
no-op in that case? Guess that's ok.

[benm (inactive), 2013/08/29 16:53:36]

Yes, that's correct AFAIU. This doesn't crash, anyway :-)

But thinking about it, as this is now a separate function that could be called
from elsewhere, I will add the null check to be safe. Also gonna alphabetise the
prefs, it's bugging me.

[joth, 2013/08/29 18:19:40]

Sounds like AwRVHExt OnRVHCreated would be the place to do this then?

[boliu, 2013/08/29 18:26:08]

Not really. When render view is created, the existing preferences is passed rv
already, so no need to call sync there. It's only after render view is created
and we want to change the preference again that we *need* to call sync.

[benm (inactive), 2013/08/30 13:47:43]

We could move to AWRHExt::OnRVCreated, - this is actually where I had this
originally, but then noticed Bo's change for tap_targets was done here in
AwContents so moved it over. Any preference?

+}
+
 void AwContents::SetAwAutofillManagerDelegate(jobject delegate) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null())
     return;
   Java_AwContents_setAwAutofillManagerDelegate(env, obj.obj(), delegate);
 }
 
 AwContents::~AwContents() {
   DCHECK(AwContents::FromWebContents(web_contents_.get()) == this);
@@ skipping 558 matching lines @@
   browser_view_renderer_->EnableOnNewPicture(enabled);
 }
 
 void AwContents::SetJsOnlineProperty(JNIEnv* env,
                                      jobject obj,
                                      jboolean network_up) {
   render_view_host_ext_->SetJsOnlineProperty(network_up);
 }
 
 }  // namespace android_webview