Refactor out duplicate code from GTK/Views extension installed bubble.

chrome/browser/ui/extensions/extension_installed_bubble.h

Index: chrome/browser/ui/extensions/extension_installed_bubble.h
diff --git a/chrome/browser/ui/extensions/extension_installed_bubble.h b/chrome/browser/ui/extensions/extension_installed_bubble.h
new file mode 100644
index 0000000000000000000000000000000000000000..4b7dc9e4dd18638ff6299eed7d49f9d3a21a62e8
--- /dev/null
+++ b/chrome/browser/ui/extensions/extension_installed_bubble.h
@@ -0,0 +1,99 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_
+#define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_
+
+#include "base/memory/weak_ptr.h"
+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "third_party/skia/include/core/SkBitmap.h"
+
+class Browser;
+
+namespace extensions {
+class Extension;
+}
+
+// Provides feedback to the user upon successful installation of an
+// extension. Depending on the type of extension, the Bubble will
+// point to:
+//    OMNIBOX_KEYWORD-> The omnibox.
+//    BROWSER_ACTION -> The browser action icon in the toolbar.
+//    PAGE_ACTION    -> A preview of the page action icon in the location
+//                      bar which is shown while the Bubble is shown.
+//    GENERIC        -> The wrench menu. This case includes page actions that
+//                      don't specify a default icon.
+//
+// ExtensionInstallBubble manages its own lifetime.
+class ExtensionInstalledBubble : public content::NotificationObserver {
+ public:
+  // The behavior and content of this Bubble comes in these varieties:
+  enum BubbleType {
+    OMNIBOX_KEYWORD,
+    BROWSER_ACTION,
+    PAGE_ACTION,
+    GENERIC
+  };
+
+  // Implements the UI for showing the bubble. Owns us.
+  class View {

[tfarina, 2013/08/29 22:19:54]

why this is an inner class? can you move it into its own header file?

can it be Delegate instead of View?

[Yoyo Zhou, 2013/09/03 19:34:36]

There's no benefit, since everyone who implements the delegate needs this header
file.
Sure, renamed.

[tfarina, 2013/09/03 19:49:13]

they need because they are referring to BubbleType?

If it's that, ok. If it is not, then forward declare ExtensionInstalledBubble in
those headers and move the delegate into its own header file.

[Yoyo Zhou, 2013/09/03 22:15:55]

As per the other comment, if I declare an ExtensionInstalledBubble on the stack
instead of a scoped_ptr...

+   public:

[tfarina, 2013/09/03 19:49:13]

virtual destructor?

[Yoyo Zhou, 2013/09/03 22:15:55]

Done.

+    // Shows the bubble. Called internally via PostTask.
+    virtual void ShowInternal() = 0;
+
+    // Informs the view that our browser is closing, so it should
+    // delete itself.
+    virtual void OnBrowserClosing() = 0;
+  };
+
+  ExtensionInstalledBubble(View* view,
+                           const extensions::Extension* extension,
+                           Browser *browser,
+                           const SkBitmap& icon);
+
+  virtual ~ExtensionInstalledBubble();
+
+  const extensions::Extension* extension() { return extension_; }
+  Browser* browser() { return browser_; }
+  const SkBitmap& icon() { return icon_; }
+  BubbleType type() { return type_; }
+  content::NotificationRegistrar* registrar() { return &registrar_; }
+
+  // When showing the bubble for a new browser action, we may have to wait for
+  // the toolbar to finish animating to know where the item's final position
+  // will be.
+  void MaybeShowLater();
+
+  // Stop listening to NOTIFICATION_BROWSER_CLOSING.
+  void IgnoreBrowserClosing();
+
+ private:
+  // Delegates showing the view to our |view_|.
+  void ShowInternal();
+
+  // content::NotificationObserver:
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  // The view delegate that shows the bubble. Owns us.
+  View* view_;
+
+  const extensions::Extension* extension_;
+  Browser* browser_;
+  const SkBitmap icon_;
+  BubbleType type_;
+  content::NotificationRegistrar registrar_;
+
+  // The number of times to retry showing the bubble if the browser action
+  // toolbar is animating.
+  int animation_wait_retries_;
+
+  base::WeakPtrFactory<ExtensionInstalledBubble> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionInstalledBubble);
+};
+
+#endif  // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_H_