Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Unified Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.h

Issue 23461013: Refactor out duplicate code from GTK/Views extension installed bubble. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..40d7cfb0bcd30b203a21a66292e4d4e3b083ccb0
--- /dev/null
+++ b/chrome/browser/ui/views/extensions/extension_installed_bubble_view.h
@@ -0,0 +1,61 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_VIEW_H_
+#define CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_VIEW_H_
+
+#include "base/compiler_specific.h"
+#include "chrome/browser/ui/extensions/extension_installed_bubble.h"
+#include "ui/views/bubble/bubble_delegate.h"
+
+class Browser;
+
+namespace extensions {
+class Extension;
+}
+
+// Provides feedback to the user upon successful installation of an
+// extension. Depending on the type of extension, the Bubble will
+// point to:
+// OMNIBOX_KEYWORD-> The omnibox.
+// BROWSER_ACTION -> The browserAction icon in the toolbar.
+// PAGE_ACTION -> A preview of the pageAction icon in the location
+// bar which is shown while the Bubble is shown.
+// GENERIC -> The wrench menu. This case includes pageActions that
+// don't specify a default icon.
+class ExtensionInstalledBubbleView
+ : public ExtensionInstalledBubble::Delegate,
+ public views::BubbleDelegateView {
+ public:
+ // Creates the ExtensionInstalledBubbleView and schedules it to be shown once
+ // the extension has loaded. |extension| is the installed extension. |browser|
+ // is the browser window which will host the bubble. |icon| is the install
+ // icon of the extension.
+ static void Show(const extensions::Extension* extension,
+ Browser *browser,
tfarina 2013/09/03 19:51:27 nit: Browser*
Yoyo Zhou 2013/09/03 22:15:55 Done.
+ const SkBitmap& icon);
+
+ private:
+ ExtensionInstalledBubbleView(const extensions::Extension* extension,
+ Browser *browser,
+ const SkBitmap& icon);
+
+ virtual ~ExtensionInstalledBubbleView();
+
+ // ExtensionInstalledBubble::Delegate
+ virtual void ShowInternal() OVERRIDE;
+ virtual void OnBrowserClosing() OVERRIDE;
+
+ // views::WidgetDelegate
tfarina 2013/09/03 19:51:27 views::WidgetDelegate:
Yoyo Zhou 2013/09/03 22:15:55 Done.
+ virtual void WindowClosing() OVERRIDE;
+
+ // views::BubbleDelegate
+ virtual gfx::Rect GetAnchorRect() OVERRIDE;
+
+ ExtensionInstalledBubble bubble_;
tfarina 2013/09/03 19:51:27 Scott prefers like this, on the stack. But I'd use
Yoyo Zhou 2013/09/03 22:15:55 In that case I'll leave it as is.
+
+ DISALLOW_COPY_AND_ASSIGN(ExtensionInstalledBubbleView);
+};
+
+#endif // CHROME_BROWSER_UI_VIEWS_EXTENSIONS_EXTENSION_INSTALLED_BUBBLE_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698