Refactor out duplicate code from GTK/Views extension installed bubble.

chrome/browser/ui/extensions/extension_installed_bubble.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/extensions/extension_installed_bubble.h"
+
+#include <string>
+
+#include "base/bind.h"
+#include "base/message_loop/message_loop.h"
+#include "base/time/time.h"
+#include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/common/extensions/api/extension_action/action_info.h"
+#include "chrome/common/extensions/api/omnibox/omnibox_handler.h"
+#include "chrome/common/extensions/extension.h"
+#include "content/public/browser/notification_details.h"
+#include "content/public/browser/notification_source.h"
+
+using extensions::Extension;
+
+namespace {
+
+// How long to wait for browser action animations to complete before retrying.
+const int kAnimationWaitMs = 50;
+// How often we retry when waiting for browser action animation to end.
+const int kAnimationWaitRetries = 10;
+
+} // namespace
+
+ExtensionInstalledBubble::ExtensionInstalledBubble(Delegate* delegate,
+                                                   const Extension* extension,
+                                                   Browser *browser,
+                                                   const SkBitmap& icon)
+    : delegate_(delegate),
+      extension_(extension),
+      browser_(browser),
+      icon_(icon),
+      animation_wait_retries_(0),
+      weak_factory_(this) {
+  if (!extensions::OmniboxInfo::GetKeyword(extension).empty())
+    type_ = OMNIBOX_KEYWORD;
+  else if (extensions::ActionInfo::GetBrowserActionInfo(extension))
+    type_ = BROWSER_ACTION;
+  else if (extensions::ActionInfo::GetPageActionInfo(extension) &&
+           extensions::ActionInfo::IsVerboseInstallMessage(extension))
+    type_ = PAGE_ACTION;
+  else
+    type_ = GENERIC;
+
+  // |extension| has been initialized but not loaded at this point. We need
+  // to wait on showing the Bubble until not only the EXTENSION_LOADED gets
+  // fired, but all of the EXTENSION_LOADED Observers have run. Only then can we
+  // be sure that a BrowserAction or PageAction has had views created which we
+  // can inspect for the purpose of previewing of pointing to them.
+  registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,
+      content::Source<Profile>(browser->profile()));
+  registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
+      content::Source<Profile>(browser->profile()));
+  registrar_.Add(this, chrome::NOTIFICATION_BROWSER_CLOSING,
+      content::Source<Browser>(browser));
+}
+
+ExtensionInstalledBubble::~ExtensionInstalledBubble() {}
+
+void ExtensionInstalledBubble::MaybeShowLater() {
+  if (animation_wait_retries_++ < kAnimationWaitRetries) {
+    base::MessageLoopForUI::current()->PostDelayedTask(
+        FROM_HERE,
+        base::Bind(&ExtensionInstalledBubble::ShowInternal,
+                   weak_factory_.GetWeakPtr()),
+        base::TimeDelta::FromMilliseconds(kAnimationWaitMs));
+  }
+}
+
+void ExtensionInstalledBubble::IgnoreBrowserClosing() {
+  registrar_.Remove(this, chrome::NOTIFICATION_BROWSER_CLOSING,
+                    content::Source<Browser>(browser_));
+}
+
+void ExtensionInstalledBubble::ShowInternal() {
+  delegate_->ShowInternal();
+}
+
+void ExtensionInstalledBubble::Observe(
+    int type,
+    const content::NotificationSource& source,
+    const content::NotificationDetails& details) {
+  if (type == chrome::NOTIFICATION_EXTENSION_LOADED) {

[sky, 2013/09/04 00:04:06]

nit: IMO you've got enough ifs to warrant a switch here.

[Yoyo Zhou, 2013/09/05 00:12:21]

Done.

+    const Extension* extension =
+        content::Details<const Extension>(details).ptr();
+    if (extension == extension_) {
+      animation_wait_retries_ = 0;
+      // PostTask to ourself to allow all EXTENSION_LOADED Observers to run.
+      base::MessageLoopForUI::current()->PostTask(
+          FROM_HERE,
+          base::Bind(&ExtensionInstalledBubble::ShowInternal,
+                     weak_factory_.GetWeakPtr()));
+    }
+  } else if (type == chrome::NOTIFICATION_EXTENSION_UNLOADED) {
+    const Extension* extension =
+        content::Details<extensions::UnloadedExtensionInfo>(details)->extension;
+    if (extension == extension_) {
+      // Extension is going away, make sure ShowInternal won't be called.
+      weak_factory_.InvalidateWeakPtrs();
+      extension_ = NULL;
+    }
+  } else if (type == chrome::NOTIFICATION_BROWSER_CLOSING) {
+    delegate_->OnBrowserClosing();
+  } else {
+    NOTREACHED() << "Received unexpected notification";
+  }
+}