Source/web/WebViewImpl.h - Issue 23461009: Scale to legibleScale if double tap would barely zoom in from zoomed out state.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.h

Issue 23461009: Scale to legibleScale if double tap would barely zoom in from zoomed out state. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebViewImpl.h

diff --git a/Source/web/WebViewImpl.h b/Source/web/WebViewImpl.h

index e900e9cba74d1bbc832d93579765c768454b157a..3a3177018f0aaefdcaa28be133d2deff7cac2380 100644

--- a/Source/web/WebViewImpl.h

+++ b/Source/web/WebViewImpl.h

@@ -526,7 +526,8 @@ public:

// a plugin can update its own zoom, say because of its own UI.

void fullFramePluginZoomLevelChanged(double zoomLevel);

- void computeScaleAndScrollForBlockRect(const WebRect& blockRect, float padding, float& scale, WebPoint& scroll, bool& doubleTapShouldZoomOut);

+ float computeLegibleScale();

aelias_OOO_until_Jul13 2013/08/29 21:34:40 Please make this private and const, and rename to

+ void computeScaleAndScrollForBlockRect(const WebRect& blockRect, float padding, float defaultScaleWhenAlreadyLegible, float& scale, WebPoint& scroll);

WebCore::Node* bestTapNode(const WebCore::PlatformGestureEvent& tapEvent);

void enableTapHighlight(const WebCore::PlatformGestureEvent& tapEvent);

void computeScaleAndScrollForFocusedNode(WebCore::Node* focusedNode, float& scale, WebCore::IntPoint& scroll, bool& needAnimation);

« no previous file with comments | « no previous file | Source/web/WebViewImpl.cpp » ('j') | no next file with comments »