Ignore Javascript urls dropped on tabs (Mac version)

chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_controller.h"
 
 #import <QuartzCore/QuartzCore.h>
 
 #include <cmath>
 #include <limits>
@@ skipping 2041 matching lines @@
     // the next iteration.)
     i++;
   }
 
   // If we've made it here, we want to append a new tab to the end.
   *index = -1;
   *disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
 }
 
 - (void)openURL:(GURL*)url inView:(NSView*)view at:(NSPoint)point {
+  // Security: Block JavaScript to prevent self-XSS.
+  if (url->SchemeIs(url::kJavaScriptScheme)) return;

[Avi (use Gerrit), 2016/09/16 19:07:49]

Strictly speaking this is allowed by the style guide, but I haven't seen it done
this way before. Can you put the "return" onto its own line? (Here and in the
other file.)

[elawrence, 2016/09/16 19:17:07]

Done.

+
   // Get the index and disposition.
   NSInteger index;
   WindowOpenDisposition disposition;
   [self droppingURLsAt:point
             givesIndex:&index
            disposition:&disposition];
 
   // Either insert a new tab or open in a current tab.
   switch (disposition) {
     case WindowOpenDisposition::NEW_FOREGROUND_TAB: {
@@ skipping 261 matching lines @@
   for (int i = 0; i < tabStripModel_->count(); i++) {
     [self updateIconsForContents:tabStripModel_->GetWebContentsAt(i) atIndex:i];
   }
 }
 
 - (void)setVisualEffectsDisabledForFullscreen:(BOOL)fullscreen {
   [tabStripView_ setVisualEffectsDisabledForFullscreen:fullscreen];
 }
 
 @end