Move XID, XDisplay, GetXDisplay and a few other types to ui/gfx/x/x11_types.h

Move XID, XDisplay, GetXDisplay and a few other types to ui/gfx/x/x11_types.h

This is to break a dependency on ui/base from ui/compositor.

R=sky@chromium.org
TBR=sky@chromium.org
BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224419

[sky, 2013-09-19 00:11:39]

https://codereview.chromium.org/23460052/diff/1/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (left):

https://codereview.chromium.org/23460052/diff/1/ui/base/x/x11_util.h#oldcode28
ui/base/x/x11_util.h:28: typedef struct _XDisplay Display;
I believe this was Display to match X, see
http://tronche.com/gui/x/xlib/display/opening.html . Are you sure you don't want
to keep it Display to match X?

[sky, 2013-09-19 00:13:49]

LGTM

https://codereview.chromium.org/23460052/diff/1/ui/base/x/x11_util.h
File ui/base/x/x11_util.h (left):

https://codereview.chromium.org/23460052/diff/1/ui/base/x/x11_util.h#oldcode28
ui/base/x/x11_util.h:28: typedef struct _XDisplay Display;
On 2013/09/19 00:11:39, sky wrote:
> I believe this was Display to match X, see
> http://tronche.com/gui/x/xlib/display/opening.html . Are you sure you don't
want
> to keep it Display to match X?

I guess this is no different than a typedef of Display to XDisplay.

[Ben Goodger (Google), 2013-09-19 04:38:49]

The other issue (maybe not an issue but something that's confusing) is that
there's also gfx::Display. The typedef is toplevel so it's distinct.

[sky, 2013-09-19 15:49:51]

Ah, ok, makes sense.

  -Scott

On Wed, Sep 18, 2013 at 9:38 PM,  <ben@chromium.org> wrote:
> The other issue (maybe not an issue but something that's confusing) is that
> there's also gfx::Display. The typedef is toplevel so it's distinct.
>
> https://codereview.chromium.org/23460052/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2013-09-20 17:41:48]

Committed patchset #7 manually as r224419 (presubmit successful).