Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Unified Diff: tests/lib/mirrors/mirrors_test.dart

Issue 23460050: Mirror removals: async invoke, mirrorSystemOf(port), Mirror.mirrors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/mirrors/mirrors.dart ('K') | « tests/lib/mirrors/invoke_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/mirrors_test.dart
diff --git a/tests/lib/mirrors/mirrors_test.dart b/tests/lib/mirrors/mirrors_test.dart
index df1f9b055c683782cd69e9c4d34f772a894c76da..d87b99074c1d2db8c662e29dadcd699064e1b59e 100644
--- a/tests/lib/mirrors/mirrors_test.dart
+++ b/tests/lib/mirrors/mirrors_test.dart
@@ -45,9 +45,6 @@ testInvoke(mirrors) {
equals("DNU"));
expect(instMirror.invoke(const Symbol("m"), []).reflectee,
equals("DNU")); // Wrong arity.
- // TODO(rmacnak): Implement access to private members.
- // expect(instMirror.invoke(const Symbol("_n"), [3, 4]).reflectee,
- // equals(7));
var classMirror = instMirror.type;
expect(classMirror.invoke(const Symbol("s"),['A', 'B', instance]).reflectee,
@@ -56,9 +53,6 @@ testInvoke(mirrors) {
throws);
expect(() => classMirror.invoke(const Symbol("s"), []).reflectee,
throws); // Wrong arity.
- // TODO(rmacnak): Implement access to private members.
- // expect(classMirror.invoke(const Symbol("_t"), [3, 4]).reflectee,
- // equals(7));
var libMirror = classMirror.owner;
expect(libMirror.invoke(const Symbol("u"),['A', 'B', instance]).reflectee,
@@ -67,21 +61,6 @@ testInvoke(mirrors) {
throws);
expect(() => libMirror.invoke(const Symbol("u"), []).reflectee,
throws); // Wrong arity.
- // NB: This works on the VM but fails at compile-time on dart2js.
- // expect(libMirror.invoke(const Symbol("_v"), [3, 4]).reflectee,
- // equals(7));
-}
-
-testInstanceFieldAccess(mirrors) {
- var instance = new Class();
- var instMirror = reflect(instance);
-
- instMirror.setFieldAsync(const Symbol('field'), 44);
- instMirror.getFieldAsync(const Symbol('field')).then(
- expectAsync1((resultMirror) {
- expect(resultMirror.reflectee, equals(44));
- expect(instance.field, equals(44));
- }));
}
/// In dart2js, lists, numbers, and other objects are treated special
@@ -124,27 +103,6 @@ testFieldAccess(mirrors) {
expect(libMirror.getField(const Symbol('topLevelField')).reflectee,
equals([91]));
expect(topLevelField, equals([91]));
-
- libMirror.setFieldAsync(const Symbol('topLevelField'), 42);
- future = libMirror.getFieldAsync(const Symbol('topLevelField'));
- future.then(expectAsync1((resultMirror) {
- expect(resultMirror.reflectee, equals(42));
- expect(topLevelField, equals(42));
- }));
-
- classMirror.setFieldAsync(const Symbol('staticField'), 43);
- future = classMirror.getFieldAsync(const Symbol('staticField'));
- future.then(expectAsync1((resultMirror) {
- expect(resultMirror.reflectee, equals(43));
- expect(Class.staticField, equals(43));
- }));
-
- instMirror.setFieldAsync(const Symbol('field'), 44);
- future = instMirror.getFieldAsync(const Symbol('field'));
- future.then(expectAsync1((resultMirror) {
- expect(resultMirror.reflectee, equals(44));
- expect(instance.field, equals(44));
- }));
}
testClosureMirrors(mirrors) {
@@ -159,11 +117,6 @@ testClosureMirrors(mirrors) {
expect(funcMirror.parameters.length, equals(3));
expect(mirror.apply([7, 8, 9]).reflectee, equals(24));
-
- var future = mirror.applyAsync([2, 4, 8]);
- future.then(expectAsync1((resultMirror) {
- expect(resultMirror.reflectee, equals(14));
- }));
}
testInvokeConstructor(mirrors) {
@@ -198,21 +151,6 @@ testInvokeConstructor(mirrors) {
[10]);
expect(instanceMirror.reflectee is Class, equals(true));
expect(instanceMirror.reflectee.field, equals(30));
-
-
- var future = classMirror.newInstanceAsync(const Symbol(''), []);
- future.then(expectAsync1((resultMirror) {
- var instance = resultMirror.reflectee;
- expect(instance is Class, equals(true));
- expect(instance.field, equals("default value"));
- }));
-
- future = classMirror.newInstanceAsync(const Symbol('withInitialValue'), [45]);
- future.then(expectAsync1((resultMirror) {
- var instance = resultMirror.reflectee;
- expect(instance is Class, equals(true));
- expect(instance.field, equals(45));
- }));
}
testReflectClass(mirrors) {
@@ -274,7 +212,6 @@ testLibraryUri(var value, bool check(Uri)) {
main() {
var mirrors = currentMirrorSystem();
test("Test reflective method invocation", () { testInvoke(mirrors); });
- test("Test instance field access", () { testInstanceFieldAccess(mirrors); });
test('Test intercepted objects', () { testIntercepted(mirrors); });
test("Test field access", () { testFieldAccess(mirrors); });
test("Test closure mirrors", () { testClosureMirrors(mirrors); });
« sdk/lib/mirrors/mirrors.dart ('K') | « tests/lib/mirrors/invoke_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698