Issue 23460038: Reduce chrome cras dbus call logs during device rebooting.

Issue 23460038: Reduce chrome cras dbus call logs during device rebooting. (Closed)

Created:
7 years, 3 months ago by jennyz

Modified:
7 years, 3 months ago

Reviewers:
rkc, Daniel Erat

CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Reduce chrome cras dbus call logs during device rebooting. cras server won't start unitl after EmitLoginPromptVisible. Start cras log after it, so that we don't log the dbus failure due to cras call is made before it is started . Also a few other changes that should remove all other excess log seen during rebooting. BUG=288177 TBR=mpcomplete Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223098

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix a nit. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -24 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/audio/audio_service_chromeos.cc	View		3 chunks	+13 lines, -1 line	0 comments	Download
M	chromeos/audio/cras_audio_handler.h	View		5 chunks	+18 lines, -3 lines	0 comments	Download
M	chromeos/audio/cras_audio_handler.cc	View		12 chunks	+52 lines, -10 lines	0 comments	Download
M	chromeos/dbus/cras_audio_client.h	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chromeos/dbus/cras_audio_client.cc	View	1	3 chunks	+28 lines, -7 lines	0 comments	Download
M	chromeos/dbus/cras_audio_client_stub_impl.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos/dbus/cras_audio_client_stub_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chromeos/dbus/session_manager_client.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/dbus/session_manager_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

lgtm https://codereview.chromium.org/23460038/diff/1/chromeos/dbus/cras_audio_client.cc File chromeos/dbus/cras_audio_client.cc (right): https://codereview.chromium.org/23460038/diff/1/chromeos/dbus/cras_audio_client.cc#newcode303 chromeos/dbus/cras_audio_client.cc:303: if (node_list.size() == 0) nit: node_list.empty() (if this ...

7 years, 3 months ago (2013-09-13 01:36:27 UTC) #1

jennyz

https://codereview.chromium.org/23460038/diff/1/chromeos/dbus/cras_audio_client.cc File chromeos/dbus/cras_audio_client.cc (right): https://codereview.chromium.org/23460038/diff/1/chromeos/dbus/cras_audio_client.cc#newcode303 chromeos/dbus/cras_audio_client.cc:303: if (node_list.size() == 0) On 2013/09/13 01:36:27, Daniel Erat ...

7 years, 3 months ago (2013-09-13 16:25:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/23460038/4001

7 years, 3 months ago (2013-09-13 16:26:04 UTC) #3

Message was sent while issue was closed.

Change committed as 223098

Expand Messages | Collapse Messages