Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chrome/chrome_syzygy.gyp

Issue 23460023: Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_syzygy.gypi » ('j') | chrome/tools/build/win/syzygy_instrument.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_syzygy.gyp
diff --git a/chrome/chrome_syzygy.gyp b/chrome/chrome_syzygy.gyp
index d4994ac1813c8432e8564dc25f185331d4a39f21..034cb67b514fbcc67932dea4cce9bd44b48d040c 100644
--- a/chrome/chrome_syzygy.gyp
+++ b/chrome/chrome_syzygy.gyp
@@ -34,5 +34,33 @@
},
],
}],
+ ['OS=="win" and asan==1 and fastbuild==0', {
gab 2013/09/09 13:26:28 Why depend on |fastbuild| here?
Sébastien Marchand 2013/09/10 17:53:42 No reason, cut-and-paste error. Thanks. On 2013/0
+ 'variables': {
+ 'dest_dir': '<(PRODUCT_DIR)/syzygy',
+ 'syzygy_exe_dir': '<(DEPTH)/third_party/syzygy/binaries/exe',
+ },
+ # Copy the SyzyASan runtime and logger to the syzygy directory.
+ 'targets': [
+ {
+ 'target_name': 'copy_syzyasan_binaries',
gab 2013/09/09 13:26:28 Shouldn't this target depend on the target generat
Sébastien Marchand 2013/09/10 17:53:42 No, the target chrome_dll_syzygy and chrome_child_
+ 'type': 'none',
+ 'outputs': [
+ '<(dest_dir)/agent_logger.exe',
+ '<(dest_dir)/asan_rtl.dll',
+ '<(dest_dir)/asan_rtl.dll.pdb',
+ ],
+ 'copies': [
+ {
+ 'destination': '<(dest_dir)',
+ 'files': [
+ '<(syzygy_exe_dir)/agent_logger.exe',
+ '<(syzygy_exe_dir)/asan_rtl.dll',
+ '<(syzygy_exe_dir)/asan_rtl.dll.pdb',
+ ],
+ },
+ ],
+ },
+ ],
+ }],
],
}
« no previous file with comments | « no previous file | chrome/chrome_syzygy.gypi » ('j') | chrome/tools/build/win/syzygy_instrument.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698