[chromium]: Annotate StringImpl::createStatic leak for LeakSanitizer.

[chromium]: Annotate StringImpl::createStatic leak for LeakSanitizer.

Changes to enable annotating known leaks in blink so that leak sanitizer doesn't raise alarm.
Removing addition of StringImpl::createStatic from tools/lsan/suppressions.txt
This patch currently just handles Leak Sanitizer only. The changes for Heap Checker would be done in a follow up patch.

BUG=268258
TEST=Running content_unittests with Leak Sanitizer enabled.
Output of Leak Sanitizer before the fix: http://pastebin.com/niDgRNAQ
Output of Leak Sanitizer after the fix: http://pastebin.com/v6hF43Lj

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221586

[r.kasibhatla, 2013-09-03 15:33:29]

This is just a preliminary patch. If the tone of changes is ok, then I will be
making the changes for heap-checker as well. Will add the
heap-checker/suppressions.txt as well to this list. Also, need to correct the
valgrind as well for removal from suppressions.txt

[earthdok, 2013-09-03 16:15:20]

lgtm, but please don't commit this immediately after the blink roll (it might
get reverted later...)

[earthdok, 2013-09-04 13:32:21]

lgtm still

[earthdok, 2013-09-04 13:32:27]

https://codereview.chromium.org/23460014/diff/5001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/23460014/diff/5001/build/common.gypi#newcode3309
build/common.gypi:3309: 'WTF_USE_LEAK_ANNOTATIONS=1',
Do you really need a separate define for this?

[r.kasibhatla, 2013-09-04 14:12:41]

On 2013/09/04 13:32:27, earthdok wrote:
> https://codereview.chromium.org/23460014/diff/5001/build/common.gypi
> File build/common.gypi (right):
> 
>
https://codereview.chromium.org/23460014/diff/5001/build/common.gypi#newcode3309
> build/common.gypi:3309: 'WTF_USE_LEAK_ANNOTATIONS=1',
> Do you really need a separate define for this?
I noticed a separate WTF_USE_DYNAMIC_ANNOTATIONS was defined for dynamic
annotations of threads (for blink), so was not sure whether we needed similarly
for leak annotations also or not. I decided to let the reviewers take the call
and added prehand, and will remove it as per review suggestions. :)

[r.kasibhatla, 2013-09-05 07:43:21]

On 2013/09/04 14:12:41, r.kasibhatla wrote:
> On 2013/09/04 13:32:27, earthdok wrote:
> > https://codereview.chromium.org/23460014/diff/5001/build/common.gypi
> > File build/common.gypi (right):
> > 
> >
>
https://codereview.chromium.org/23460014/diff/5001/build/common.gypi#newcode3309
> > build/common.gypi:3309: 'WTF_USE_LEAK_ANNOTATIONS=1',
> > Do you really need a separate define for this?
> I noticed a separate WTF_USE_DYNAMIC_ANNOTATIONS was defined for dynamic
> annotations of threads (for blink), so was not sure whether we needed
similarly
> for leak annotations also or not. I decided to let the reviewers take the call
> and added prehand, and will remove it as per review suggestions. :)

Removed WTF_USE_LEAK_ANNOTATIONS=1 as per your suggestion.

[commit-bot: I haz the power, 2013-09-05 19:21:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/23460014/13001

[commit-bot: I haz the power, 2013-09-06 05:40:55]

Change committed as 221586