Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 23460013: Implement InstanceMirror.== in dart2js and InstanceMirror.hashCode in the VM and … (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: use isolate parameter to native Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index ddf05f0b479aa7aca42051136c7ff83eb154d10d..304b0a863fdca617e53e3cf7dae52d3ea39bb459 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -283,8 +283,21 @@ class _LocalInstanceMirrorImpl extends _LocalObjectMirrorImpl
identical(_reflectee, other._reflectee);
}
- // TODO(12909): Use the reflectee's identity hash.
- int get hashCode => _reflectee.hashCode;
+ int get hashCode {
+ // If the reflectee is a double or bignum, use the base hashCode to preserve
+ // the illusion that boxed numbers with the same value are identical. If the
+ // reflectee is a Smi, use the base hashCode because Object.hashCode does
+ // not work for non-heap objects. Otherwise, use Object.hashCode to maintain
+ // correctness even if a user-defined hashCode returns different values for
+ // successive invocations.
+ var h = _reflectee is num ? _reflectee.hashCode : _identityHash(_reflectee);
+ // Avoid hash collisions with the reflectee. This constant is in Smi range
+ // and happens to be the inner padding from RFC 2104.
+ return h ^ 0x36363636;
+ }
+
+ static _identityHash(reflectee)
+ native "InstanceMirror_identityHash";
_invoke(reflectee, functionName, positionalArguments)
native 'InstanceMirror_invoke';
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698