Merge IBusContorllerBase into IBusControllerImpl.

chrome/browser/chromeos/input_method/ibus_controller_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "chrome/browser/chromeos/input_method/ibus_controller_impl.h"
 #include "chromeos/ime/input_method_property.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 namespace input_method {
 
 namespace {
 
 bool FindAndUpdateProperty(const InputMethodProperty& new_prop,
                            InputMethodPropertyList* prop_list) {
   return IBusControllerImpl::FindAndUpdatePropertyForTesting(new_prop,
                                                              prop_list);
 }
 
+// A mock class for testing AddObserver() and RemoveObserver() methods
+// in IBusControllerImpl.
+class TestIBusController : public IBusControllerImpl {
+ public:
+  TestIBusController() {
+  }
+  virtual ~TestIBusController() {

[Seigo Nonaka, 2013/08/27 11:31:12]

nit: please add one line break above.

[Hiro Komatsu, 2013/08/28 01:41:28]

Done.

+  }
+
+  bool HasObservers() const {
+    return observers_.might_have_observers();
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestIBusController);
+};
+
+class TestObserver : public IBusController::Observer {
+ public:
+  // IBusController::Observer overrides:
+  virtual void PropertyChanged() OVERRIDE {}
+};
 }  // namespace
 
 TEST(IBusControllerImplTest, TestFindAndUpdateProperty) {
   InputMethodPropertyList properties;
   EXPECT_FALSE(FindAndUpdateProperty(InputMethodProperty(), &properties));
 
   properties.push_back(
       InputMethodProperty("key1", "label1", false, false));
   EXPECT_FALSE(FindAndUpdateProperty(InputMethodProperty(), &properties));
   EXPECT_FALSE(FindAndUpdateProperty(
@@ skipping 11 matching lines @@
   EXPECT_FALSE(FindAndUpdateProperty(
       InputMethodProperty("keyX", "labelX", false, false), &properties));
   EXPECT_EQ(InputMethodProperty("key2", "label2", false, false),
             properties[1]);
   EXPECT_TRUE(FindAndUpdateProperty(
       InputMethodProperty("key2", "labelZ", false, false), &properties));
   EXPECT_EQ(InputMethodProperty("key2", "labelZ", false, false),
             properties[1]);
 }
 
+TEST(IBusControllerImplTest, TestAddRemoveObserver) {
+  IBusBridge::Initialize();
+  {
+    TestIBusController controller;
+    TestObserver observer1;
+    TestObserver observer2;
+    TestObserver observer3;
+    EXPECT_FALSE(controller.HasObservers());
+    controller.AddObserver(&observer1);
+    EXPECT_TRUE(controller.HasObservers());
+    controller.AddObserver(&observer2);
+    EXPECT_TRUE(controller.HasObservers());
+    controller.RemoveObserver(&observer3);  // nop
+    EXPECT_TRUE(controller.HasObservers());
+    controller.RemoveObserver(&observer1);
+    EXPECT_TRUE(controller.HasObservers());
+    controller.RemoveObserver(&observer1);  // nop
+    EXPECT_TRUE(controller.HasObservers());
+    controller.RemoveObserver(&observer2);
+    EXPECT_FALSE(controller.HasObservers());
+  }
+  IBusBridge::Shutdown();
+}
+
+TEST(IBusControllerImplTest, TestGetCurrentProperties) {
+  IBusBridge::Initialize();
+  {
+    IBusControllerImpl controller;
+    EXPECT_EQ(0U, controller.GetCurrentProperties().size());
+  }
+  IBusBridge::Shutdown();
+}
+
 }  // namespace input_method
 }  // namespace chromeos