Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2345963002: [css-grid] Prettify the nested-grid.html perf test (Closed)

Created:
4 years, 3 months ago by svillar
Modified:
4 years, 3 months ago
Reviewers:
jfernandez
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Prettify the nested-grid.html perf test Grid items have now a fixed height so that the grid could be seen when opening the test with a browser. This artificially improves the runs/s of the test because a fixed height is much cheaper to compute than an auto height, but we do not plan to change it so the test will still be sensitive to layout regressions. Committed: https://crrev.com/556444f7441e1693d8cd4b0e23896f228cc238f6 Cr-Commit-Position: refs/heads/master@{#419154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/PerformanceTests/Layout/nested-grid.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
svillar
4 years, 3 months ago (2016-09-16 12:20:35 UTC) #2
jfernandez
lgtm
4 years, 3 months ago (2016-09-16 12:21:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345963002/1
4 years, 3 months ago (2016-09-16 12:22:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-16 13:28:17 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 13:29:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/556444f7441e1693d8cd4b0e23896f228cc238f6
Cr-Commit-Position: refs/heads/master@{#419154}

Powered by Google App Engine
This is Rietveld 408576698