Break chrome_initial's dependence on //components/startup_metric_utils/browser:lib

chrome/app/chrome_main_delegate.cc

Index: chrome/app/chrome_main_delegate.cc
diff --git a/chrome/app/chrome_main_delegate.cc b/chrome/app/chrome_main_delegate.cc
index aed0427230ba5a2cc4661c62f0c0597b37188047..087bdf001e43302c73a2f5d7bb7a7b5ee3ae5b27 100644
--- a/chrome/app/chrome_main_delegate.cc
+++ b/chrome/app/chrome_main_delegate.cc
@@ -434,8 +434,12 @@ void InitLogging(const std::string& process_type) {
 #endif
 
 #if !defined(CHROME_MULTIPLE_DLL_CHILD)
-void RecordMainStartupMetrics() {
+void RecordMainStartupMetrics(int64_t exe_entry_point_ticks) {

[fdoray, 2016/09/19 17:03:28]

base::TimeTicks

[grt (UTC plus 2), 2016/09/19 19:52:46]

Done.

 #if defined(OS_MACOSX) || defined(OS_WIN) || defined(OS_LINUX)
+  if (exe_entry_point_ticks) {
+    startup_metric_utils::RecordExeMainEntryPointTicks(
+        base::TimeTicks::FromInternalValue(exe_entry_point_ticks));
+  }
   // Record the startup process creation time on supported platforms.
   startup_metric_utils::RecordStartupProcessCreationTime(
       base::CurrentProcessInfo::CreationTime());
@@ -454,13 +458,15 @@ void RecordMainStartupMetrics() {
 
 }  // namespace
 
-ChromeMainDelegate::ChromeMainDelegate() {
+ChromeMainDelegate::ChromeMainDelegate() : ChromeMainDelegate(0) {}

[brucedawson, 2016/09/16 21:38:39]

I hadn't realized that delegating constructors were approved. Cool.

But, what is the advantage over having a default value for the argument?

[grt (UTC plus 2), 2016/09/17 09:30:05]

Default values for args are somewhat discouraged by the style guide. There's not
a huge difference, I don't think.

+
+ChromeMainDelegate::ChromeMainDelegate(int64_t exe_entry_point_ticks) {
 #if !defined(CHROME_MULTIPLE_DLL_CHILD)
   // Record startup metrics in the browser process. For component builds, there
   // is no way to know the type of process (process command line is not yet
   // initialized), so the function below will also be called in renderers.
   // This doesn't matter as it simply sets global variables.
-  RecordMainStartupMetrics();
+  RecordMainStartupMetrics(exe_entry_point_ticks);
 #endif  // !defined(CHROME_MULTIPLE_DLL_CHILD)
 }