components/startup_metric_utils/browser/startup_metric_utils.h - Issue 2345933002: Break chrome_initial's dependence on //components/startup_metric_utils/browser:lib

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/startup_metric_utils/browser/startup_metric_utils.h

Issue 2345933002: Break chrome_initial's dependence on //components/startup_metric_utils/browser:lib (Closed)

Patch Set: fdoray feedback Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/startup_metric_utils/browser/startup_metric_utils.h

diff --git a/components/startup_metric_utils/browser/startup_metric_utils.h b/components/startup_metric_utils/browser/startup_metric_utils.h

index 4029ffb05721e66fa68c6268f5a13554a0725f5f..90e827468bf2214fc46b76ade67e245af679da36 100644

--- a/components/startup_metric_utils/browser/startup_metric_utils.h

+++ b/components/startup_metric_utils/browser/startup_metric_utils.h

@@ -45,7 +45,7 @@ void RecordMainEntryPointTime(const base::Time& time);

// Call this with the time when the executable is loaded and main() is entered.

// Can be different from |RecordMainEntryPointTime| when the startup process is

// contained in a separate dll, such as with chrome.exe / chrome.dll on Windows.

-void RecordExeMainEntryPointTime(const base::Time& time);

+void RecordExeMainEntryPointTicks(const base::TimeTicks& time);

grt (UTC plus 2) 2016/09/20 19:20:27 I left this as const-ref for consistency with the

// Call this with the time recorded just before the message loop is started.

// |is_first_run| - is the current launch part of a first run. |pref_service| is