Break chrome_initial's dependence on //components/startup_metric_utils/browser:lib

chrome/app/chrome_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_main_delegate.h"
 
 #include "build/build_config.h"
 #include "chrome/common/features.h"
 #include "content/public/app/content_main.h"
 
 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
 #include "base/command_line.h"
 #include "chrome/app/mash/mash_runner.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/debug/dump_without_crashing.h"
 #include "base/win/win_util.h"
 #include "chrome/common/chrome_constants.h"
 
 #define DLLEXPORT __declspec(dllexport)
 
 // We use extern C for the prototype DLLEXPORT to avoid C++ name mangling.
 extern "C" {
 DLLEXPORT int __cdecl ChromeMain(HINSTANCE instance,
-                                 sandbox::SandboxInterfaceInfo* sandbox_info);
+                                 sandbox::SandboxInterfaceInfo* sandbox_info,
+                                 int64_t exe_entry_point_ticks);

[fdoray, 2016/09/19 17:03:28]

#include <stdint.h>?

[fdoray, 2016/09/19 17:03:28]

Could it be base::TimeTicks instead of int64_t? Or that doesn't work with
DLLEXPORT __cdecl?

[grt (UTC plus 2), 2016/09/19 19:52:46]

Done.

[grt (UTC plus 2), 2016/09/19 19:52:46]

It's safest to stick to primitive types when crossing a boundary like this.
Since we expect the two binaries to be built with the same compiler at the same
time, it may be safe to use base::TimeTicks, but I'm inclined to be
conservative. Feel free to ask Siggi what he thinks if you find the int64_t bit
distasteful.

 }
 #elif defined(OS_POSIX)
 extern "C" {
 __attribute__((visibility("default")))
 int ChromeMain(int argc, const char** argv);
 }
 #endif
 
 #if defined(OS_WIN)
 DLLEXPORT int __cdecl ChromeMain(HINSTANCE instance,
-                                 sandbox::SandboxInterfaceInfo* sandbox_info) {
+                                 sandbox::SandboxInterfaceInfo* sandbox_info,
+                                 int64_t exe_entry_point_ticks) {
 #elif defined(OS_POSIX)
 int ChromeMain(int argc, const char** argv) {
+  int64_t exe_entry_point_ticks = 0;
 #endif
 #if defined(OS_WIN) && defined(ARCH_CPU_X86_64)
   // VS2013 only checks the existence of FMA3 instructions, not the enabled-ness
   // of them at the OS level (this is fixed in VS2015). We force off usage of
   // FMA3 instructions in the CRT to avoid using that path and hitting illegal
   // instructions when running on CPUs that support FMA3, but OSs that don't.
   // See http://crbug.com/436603.
   _set_FMA3_enable(0);
 #endif  // WIN && ARCH_CPU_X86_64
 
-  ChromeMainDelegate chrome_main_delegate;
+  ChromeMainDelegate chrome_main_delegate(exe_entry_point_ticks);
   content::ContentMainParams params(&chrome_main_delegate);
 
 #if defined(OS_WIN)
   // The process should crash when going through abnormal termination.
   base::win::SetShouldCrashOnProcessDetach(true);
   base::win::SetAbortBehaviorForCrashReporting();
   params.instance = instance;
   params.sandbox_info = sandbox_info;
 
   // SetDumpWithoutCrashingFunction must be passed the DumpProcess function
@@ skipping 22 matching lines @@
 #endif
 
   int rv = content::ContentMain(params);
 
 #if defined(OS_WIN)
   base::win::SetShouldCrashOnProcessDetach(false);
 #endif
 
   return rv;
 }