[chrome_elf] NTRegistry - added wow64 redirection support.

chrome_elf/blacklist/test/blacklist_test_main_dll.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_elf/blacklist/blacklist.h"
 
 #include <windows.h>
 
 #include "chrome/install_static/install_util.h"
 #include "chrome_elf/nt_registry/nt_registry.h"
 
 namespace {
 
 void GetIpcOverrides() {
   DWORD buffer_size = ::GetEnvironmentVariableW(L"hkcu_override", nullptr, 0);
   if (buffer_size > 0) {
-    wchar_t* content = new wchar_t[buffer_size];
+    std::wstring content;

[grt (UTC plus 2), 2016/09/30 09:32:16]

nit: construct the string with the desired size:
    std::wstring content(buffer_size, '\0');
and remove the resize

[penny, 2016/10/01 01:44:25]

Nice one.  It's unfortunate there's no constructor with just the size.  I don't
need the contents to be zeroed. Oh well, I suppose I'm not really using the
object as intended here.

[grt (UTC plus 2), 2016/10/02 20:10:54]

resize(buffer_size) zero-fills it as well, so the form i suggested is only
marginally better (construct with the right size rather than construct and then
alloc). reserve(buffer_size) would allocate the memory, but you still couldn't
touch it. meh.

+    content.resize(buffer_size);
     buffer_size =
-        ::GetEnvironmentVariableW(L"hkcu_override", content, buffer_size);
+        ::GetEnvironmentVariableW(L"hkcu_override", &content[0], buffer_size);
     if (buffer_size)
-      ::wcsncpy(nt::HKCU_override, content, nt::g_kRegMaxPathLen - 1);
-    delete[] content;
+      nt::SetTestingOverride(nt::HKCU, content);
   }
 
   buffer_size = ::GetEnvironmentVariableW(L"hklm_override", nullptr, 0);
   if (buffer_size > 0) {
-    wchar_t* content = new wchar_t[buffer_size];
+    std::wstring content;
+    content.resize(buffer_size);
     buffer_size =
-        ::GetEnvironmentVariableW(L"hklm_override", content, buffer_size);
+        ::GetEnvironmentVariableW(L"hklm_override", &content[0], buffer_size);
     if (buffer_size)
-      ::wcsncpy(nt::HKLM_override, content, nt::g_kRegMaxPathLen - 1);
-    delete[] content;
+      nt::SetTestingOverride(nt::HKLM, content);
   }
 
   return;
 }
 
 }  // namespace
 
 extern "C" __declspec(dllexport) void InitTestDll() {
   // Make sure we've got the latest registry overrides.
   GetIpcOverrides();
 }
 
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
     GetIpcOverrides();
     install_static::InitializeProcessType();
     blacklist::Initialize(true);  // force always on, no beacon
   }
 
   return TRUE;
 }