[chrome_elf] NTRegistry - added wow64 redirection support.

chrome_elf/nt_registry/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//testing/test.gni")
 
 assert(is_win)
 
 # This target only contains utility functions which must only depend on
 # kernel32. Please don't add dependencies on other system libraries.
 static_library("nt_registry") {
   sources = [
     "../../sandbox/win/src/nt_internals.h",
     "nt_registry.cc",
     "nt_registry.h",
   ]
 
   libs = [ "kernel32.lib" ]
 }
+
+##------------------------------------------------------------------------------
+## tests
+##------------------------------------------------------------------------------
+
+test("nt_registry_unittests") {
+  output_name = "nt_registry_unittests"
+  sources = [
+    "test/nt_registry_test.cc",

[grt (UTC plus 2), 2016/09/20 10:39:53]

please rename nt_registry_test.cc to nt_registry_unittest.cc and move it up one
dir; tests should live next to the files they are testing
(https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...).

is there a technical reason why this needs to be a new test binary? if not,
please add it to the existing elf unittest exe. if there is, it looks like you
can delete run_all_unittests.cc and instead take a dependency on
//base/test:run_all_unittests.

[penny, 2016/09/23 23:50:57]

Done.

I was following the structure of chrome_elf\blacklist and chrome_elf\hook_util. 
I've now restructured, renamed, and moved NTRegistry tests back into
chrome_elf_unittests.  

The nt_registry project is really independent of chrome_elf, so I've been making
it as self-contained as possible.  For now though, it's easy enough to have the
tests all together - especially given where the project is located in the source
tree.

Thanks for the coding standard link on the naming, TIL.

+    "test/run_all_unittests.cc",
+  ]
+  deps = [
+    ":nt_registry",
+    "//base",
+    "//base/test:test_support",
+    "//testing/gtest",
+  ]
+}