Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6073)

Unified Diff: chrome/browser/net/net_error_tab_helper.h

Issue 2345913002: Fix NetErrorTabHelper with PlzNavigate. (Closed)
Patch Set: fix NavigationHandle::IsErrorPage for reloads of error pages Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/net_error_tab_helper.h
diff --git a/chrome/browser/net/net_error_tab_helper.h b/chrome/browser/net/net_error_tab_helper.h
index 9b4155b50d34b5654b2531003ae22e000766375a..536dddbc8df33a05607c70837e2a09bdcfc98a27 100644
--- a/chrome/browser/net/net_error_tab_helper.h
+++ b/chrome/browser/net/net_error_tab_helper.h
@@ -51,28 +51,10 @@ class NetErrorTabHelper
// content::WebContentsObserver implementation.
void RenderFrameCreated(content::RenderFrameHost* render_frame_host) override;
-
- void DidStartNavigationToPendingEntry(
- const GURL& url,
- content::ReloadType reload_type) override;
-
- void DidStartProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page,
- bool is_iframe_srcdoc) override;
-
- void DidCommitProvisionalLoadForFrame(
- content::RenderFrameHost* render_frame_host,
- const GURL& url,
- ui::PageTransition transition_type) override;
-
- void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- bool was_ignored_by_handler) override;
-
+ void DidStartNavigation(
+ content::NavigationHandle* navigation_handle) override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
bool OnMessageReceived(const IPC::Message& message,
content::RenderFrameHost* render_frame_host) override;
@@ -106,7 +88,7 @@ class NetErrorTabHelper
// Relates to offline pages handling.
#if BUILDFLAG(ANDROID_JAVA_UI)
- void UpdateHasOfflinePages(content::RenderFrameHost* render_frame_host);
+ void UpdateHasOfflinePages(int frame_tree_node_id);
void SetHasOfflinePages(int frame_tree_node_id, bool has_offline_pages);
void ShowOfflinePages();
bool IsFromErrorPage() const;
« no previous file with comments | « no previous file | chrome/browser/net/net_error_tab_helper.cc » ('j') | chrome/browser/net/net_error_tab_helper_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698