Make CString more similar to WTF::String.

Make CString more similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)

Committed: https://crrev.com/ff1792acd2b28dee67159754e0c525031adc4c40
Cr-Commit-Position: refs/heads/master@{#419115}

[esprehn, 2016-09-16 02:20:57]

Description was changed from

==========
Simplify CString and make it very similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.
==========

to

==========
Simplify CString and make it very similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)
==========

[esprehn, 2016-09-16 02:24:23]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 02:24:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 02:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:33:13]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[esprehn, 2016-09-16 02:41:28]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 02:41:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 02:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 02:51:37]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[esprehn, 2016-09-16 03:40:52]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 03:41:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 05:11:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 05:11:18]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-09-16 06:04:29]

Description was changed from

==========
Simplify CString and make it very similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)
==========

to

==========
Make CString immutable like WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)
==========

[esprehn, 2016-09-16 06:05:22]

Description was changed from

==========
Make CString immutable like WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)
==========

to

==========
Make CString more similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)
==========

[esprehn, 2016-09-16 06:05:36]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[haraken, 2016-09-16 06:12:28]

LGTM

[esprehn, 2016-09-16 06:42:44]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-09-16 06:42:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 06:47:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-16 06:50:00]

Description was changed from

==========
Make CString more similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)
==========

to

==========
Make CString more similar to WTF::String.

Nothing uses the copy on write feature, and it's implemented in a
somewhat confusing way since mutableData() would create a copy of the
underlying buffer, but any instances created from the CString after
calling mutableData() would still share with the mutable buffer allowing
modification of all of the CString instances. Instead lets just remove
this feature.

Doing this makes CString and CStringBuffer immutable and makes their
API look very similar to String and StringImpl. A future patch will
rename CStringBuffer to CStringImpl to match.

I also threw in a bunch of documentation comments. :)

Committed: https://crrev.com/ff1792acd2b28dee67159754e0c525031adc4c40
Cr-Commit-Position: refs/heads/master@{#419115}
==========

[commit-bot: I haz the power, 2016-09-16 06:50:02]

Patchset 3 (id:??) landed as
https://crrev.com/ff1792acd2b28dee67159754e0c525031adc4c40
Cr-Commit-Position: refs/heads/master@{#419115}