[Devtools] Add capability for the log domain

third_party/WebKit/Source/devtools/front_end/sdk/Target.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @extends {Protocol.Agents}
  * @param {!WebInspector.TargetManager} targetManager
@@ skipping 16 matching lines @@
 
     /** @type {!Map.<!Function, !WebInspector.SDKModel>} */
     this._modelByConstructor = new Map();
 }
 
 /**
  * @enum {number}
  */
 WebInspector.Target.Capability = {
     Browser: 1,
-    JS: 2,
-    Network: 4,
-    Worker: 8,
-    DOM: 16
-}
+    DOM: 2,
+    JS: 4,
+    Log: 8,
+    Network: 16,
+    Worker: 32
+};
+
+WebInspector.Target.PAGE_CAPABILITIES =

[dgozman, 2016/09/16 01:39:35]

We don't use SHOUTY_CASE.

[eostroukhov, 2016/09/16 20:42:44]

Removed the constants altogether.

+    WebInspector.Target.Capability.Browser | WebInspector.Target.Capability.DOM |
+    WebInspector.Target.Capability.JS | WebInspector.Target.Capability.Log |
+    WebInspector.Target.Capability.Network | WebInspector.Target.Capability.Worker;
+
+WebInspector.Target.SHARED_WORKER_CAPABILITIES =
+    WebInspector.Target.Capability.Browser | WebInspector.Target.Capability.Log |
+    WebInspector.Target.Capability.Network | WebInspector.Target.Capability.Worker;
+
+WebInspector.Target.SERVICE_WORKER_CAPABILITIES =

[dgozman, 2016/09/16 01:39:35]

I don't think these constants improve things. Having them makes me think why 
don't we have a target type instead, and we deliberately switched from that.
Also, they introduce a layering violation - sdk knows about different modes we
operate which is unnecessary.

[eostroukhov, 2016/09/16 20:42:44]

Done.

+    WebInspector.Target.Capability.Log | WebInspector.Target.Capability.Network |
+    WebInspector.Target.Capability.Worker;
+
+WebInspector.Target.WORKER_CAPABILITIES =
+    WebInspector.Target.Capability.JS | WebInspector.Target.Capability.Log;
 
 WebInspector.Target._nextId = 1;
 
 WebInspector.Target.prototype = {
     /**
      * @return {number}
      */
     id: function()
     {
         return this._id;
@@ skipping 64 matching lines @@
      * @return {boolean}
      */
     hasJSCapability: function()
     {
         return this.hasAllCapabilities(WebInspector.Target.Capability.JS);
     },
 
     /**
      * @return {boolean}
      */
+    hasLogCapability: function()
+    {
+        return this.hasAllCapabilities(WebInspector.Target.Capability.Log);
+    },
+
+    /**
+     * @return {boolean}
+     */
     hasNetworkCapability: function()
     {
         return this.hasAllCapabilities(WebInspector.Target.Capability.Network);
     },
 
     /**
      * @return {boolean}
      */
     hasWorkerCapability: function()
     {
@@ skipping 137 matching lines @@
     {
         var target = /** @type {!WebInspector.Target} */ (event.data);
         if (target !== this._target)
             return;
         this.dispose();
         WebInspector.targetManager.removeEventListener(WebInspector.TargetManager.Events.TargetDisposed, this._targetDisposed, this);
     },
 
     __proto__: WebInspector.SDKObject.prototype
 }