[Devtools] Add capability for the log domain

[Devtools] Add capability for the log domain

BUG=594160
Committed: https://crrev.com/e0f27b9808ea6a7333669e2404be671fd4231d00
Cr-Commit-Position: refs/heads/master@{#419304}

[eostroukhov, 2016-09-15 23:12:26]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 23:12:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2016-09-15 23:13:40]

Description was changed from

==========
[Devtools] Add capability for the log domain

BUG=
==========

to

==========
[Devtools] Add capability for the log domain

BUG=594160
==========

[eostroukhov, 2016-09-15 23:13:40]

eostroukhov@chromium.org changed reviewers:
+ dgozman@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:56:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 00:56:30]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-16 01:39:35]

https://codereview.chromium.org/2345873002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2345873002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:44:
WebInspector.Target.PAGE_CAPABILITIES =
We don't use SHOUTY_CASE.

https://codereview.chromium.org/2345873002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:53:
WebInspector.Target.SERVICE_WORKER_CAPABILITIES =
I don't think these constants improve things. Having them makes me think why 
don't we have a target type instead, and we deliberately switched from that.
Also, they introduce a layering violation - sdk knows about different modes we
operate which is unnecessary.

[eostroukhov, 2016-09-16 20:41:45]

The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-16 20:42:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eostroukhov, 2016-09-16 20:42:44]

Thank you for the review. Please take another look.

https://codereview.chromium.org/2345873002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/2345873002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:44:
WebInspector.Target.PAGE_CAPABILITIES =
On 2016/09/16 01:39:35, dgozman wrote:
> We don't use SHOUTY_CASE.

Removed the constants altogether.

https://codereview.chromium.org/2345873002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/Target.js:53:
WebInspector.Target.SERVICE_WORKER_CAPABILITIES =
On 2016/09/16 01:39:35, dgozman wrote:
> I don't think these constants improve things. Having them makes me think why 
> don't we have a target type instead, and we deliberately switched from that.
> Also, they introduce a layering violation - sdk knows about different modes we
> operate which is unnecessary.

Done.

[dgozman, 2016-09-16 21:26:50]

lgtm

[eostroukhov, 2016-09-16 21:31:44]

The CQ bit was unchecked by eostroukhov@chromium.org

[eostroukhov, 2016-09-16 21:31:45]

The CQ bit was checked by eostroukhov@chromium.org

[eostroukhov, 2016-09-16 21:31:50]

The CQ bit was checked by eostroukhov@chromium.org

[commit-bot: I haz the power, 2016-09-16 21:32:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 22:31:26]

Description was changed from

==========
[Devtools] Add capability for the log domain

BUG=594160
==========

to

==========
[Devtools] Add capability for the log domain

BUG=594160
==========

[commit-bot: I haz the power, 2016-09-16 22:31:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 22:34:48]

Description was changed from

==========
[Devtools] Add capability for the log domain

BUG=594160
==========

to

==========
[Devtools] Add capability for the log domain

BUG=594160

Committed: https://crrev.com/e0f27b9808ea6a7333669e2404be671fd4231d00
Cr-Commit-Position: refs/heads/master@{#419304}
==========

[commit-bot: I haz the power, 2016-09-16 22:34:49]

Patchset 2 (id:??) landed as
https://crrev.com/e0f27b9808ea6a7333669e2404be671fd4231d00
Cr-Commit-Position: refs/heads/master@{#419304}