Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2345863002: [Blink, RemotePlayback] Rename connect() to prompt() (Closed)

Created:
4 years, 3 months ago by whywhat
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, haraken, mlamouri+watch-blink_chromium.org, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink, RemotePlayback] Rename connect() to prompt() BUG=647441 TEST=avayvod.github.io/remote-playback/test.html Committed: https://crrev.com/057643e80453b5733b4997258eee9227ef99ce45 Cr-Commit-Position: refs/heads/master@{#421103}

Patch Set 1 #

Patch Set 2 : Updated global interface listing expected results #

Patch Set 3 : Corrected method vs setter order #

Patch Set 4 : Removed trailing newline #

Patch Set 5 : updated the listing again #

Patch Set 6 : Rebase #

Messages

Total messages: 34 (22 generated)
whywhat
PTaL
4 years, 3 months ago (2016-09-15 23:04:25 UTC) #4
whywhat
Updated global interface listing expected results
4 years, 3 months ago (2016-09-16 00:28:21 UTC) #5
whywhat
Corrected method vs setter order
4 years, 3 months ago (2016-09-16 00:31:11 UTC) #8
whywhat
Removed trailing newline
4 years, 3 months ago (2016-09-16 19:55:30 UTC) #13
whywhat
updated the listing again
4 years, 3 months ago (2016-09-16 22:23:07 UTC) #18
mlamouri (slow - plz ping)
lgtm
4 years, 3 months ago (2016-09-22 09:26:04 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345863002/80001
4 years, 3 months ago (2016-09-23 10:13:47 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/298478)
4 years, 3 months ago (2016-09-23 10:34:48 UTC) #27
whywhat
Rebase
4 years, 2 months ago (2016-09-27 00:40:49 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345863002/100001
4 years, 2 months ago (2016-09-27 00:43:25 UTC) #31
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 2 months ago (2016-09-27 04:34:06 UTC) #32
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 04:36:01 UTC) #34
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/057643e80453b5733b4997258eee9227ef99ce45
Cr-Commit-Position: refs/heads/master@{#421103}

Powered by Google App Engine
This is Rietveld 408576698