Restore unittests

pkg/dev_compiler/test/browser/language_tests.js

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 define(['dart_sdk', 'async_helper', 'unittest', 'require'],
       function(dart_sdk, async_helper, unittest, require) {
   'use strict';
 
   async_helper = async_helper.async_helper;
 
@@ skipping 18 matching lines @@
   // there are a lot of broken html unittests.
   let num_expected_unittest_fails = 3;
   let num_expected_unittest_errors = 2;
 
   // TODO(jmesserly): separate StrongModeError from other errors.
   let all_status = {
     'language': {
       'assert_with_type_test_or_cast_test': skip_fail,
       'assertion_test': skip_fail,
       'async_await_test_none_multi': 'unittest',
+      'async_await_test_02_multi': 'unittest',
       'async_await_test_03_multi': skip_fail,  // Flaky on travis (#634)
       'async_star_await_pauses_test': skip_fail,
 
       // TODO(jmesserly): figure out why this test is hanging.
       'async_star_cancel_and_throw_in_finally_test': skip_timeout,
 
       'async_star_cancel_while_paused_test': skip_fail,
       'async_star_regression_fisk_test': skip_fail,
 
       // TODO(vsm): Re-enable.
@@ skipping 334 matching lines @@
       'default_arguments_test': fail
     },
 
     'lib/convert': {
       'encoding_test': skip_timeout,
 
       // TODO(jmesserly): this is in an inconsistent state between our old and
       // newer SDKs.
       'html_escape_test': ['skip'],
 
-      // TODO(rnystrom): If this test is enabled, karma gets confused and
-      // disconnects randomly.
-      'json_lib_test': skip_fail,
+      'json_lib_test': 'unittest',
 
       'json_utf8_chunk_test': skip_timeout,
       'latin1_test': skip_timeout,
 
       'streamed_conversion_json_encode1_test': skip_timeout,
       'streamed_conversion_json_utf8_decode_test': skip_timeout,
       'streamed_conversion_json_utf8_encode_test': skip_timeout,
       'streamed_conversion_utf8_decode_test': skip_timeout,
       'streamed_conversion_utf8_encode_test': skip_timeout,
       'utf85_test': skip_timeout,
@@ skipping 330 matching lines @@
     return matches ? matches.length : 0;
   }
   function libraryName(name) {
     return name.replace(/-/g, '$45');
   }
 
   let unittest_tests = [];
 
   let languageTestPattern =
       new RegExp('gen/codegen_output/(.*)/([^/]*_test[^/]*)');
-  html_config.useHtmlConfiguration();
   // We need to let Dart unittest control when tests are run not mocha.
   // mocha.allowUncaught(true);
   for (let testFile of allTestFiles) {
     let match = languageTestPattern.exec(testFile);
     if (match != null) {
       let status_group = match[1];
       let name = match[2];
       let module = match[0];
 
       let status = all_status[status_group];
@@ skipping 62 matching lines @@
           } else {
             mainLibrary.main();
           }
         }
 
         if (!async_helper.asyncTestStarted) done();
       });
     }
   }
 
-  // TODO(jmesserly): unitttest tests are currently broken
-  // https://github.com/dart-lang/dev_compiler/issues/631
-  return;
-
   let mochaOnError;
   // We run these tests in a mocha test wrapper to avoid the confusing failure
   // case of dart unittests being interleaved with mocha tests.
   // In practice we are really just suppressing all mocha test behavior while
   // Dart unittests run and then re-enabling it when the dart tests complete.
+  html_config.useHtmlConfiguration();
   test('run all dart unittests', function(done) { // 'function' to allow `this.timeout`
     if (unittest_tests.length == 0) return done();
 
+    // TODO(vsm): We're using an old deprecated version of unittest.
+    // We need to migrate all tests (in the SDK itself) off of
+    // unittest.
+
+    // All unittests need to be explicitly marked as such above.  If
+    // not, the unittest framework will be run in a 'normal' test and
+    // left in an inconsistent state at this point triggering spurious
+    // failures.  This check ensures we're not in such a state.  If it fails,
+    // we've likely added a new unittest and need to categorize it as such.
+    if (unittest.src__test_environment.environment.testCases[dart_sdk.dartx.length] != 0) {

[Bob Nystrom, 2016/09/16 17:04:35]

Nit: long line.

+      return done(new Error('Unittest framework in an invalid state'));
+    }
+
     this.timeout(100000000);
     this.enableTimeouts(false);
     // Suppress mocha on-error handling because it will mess up unittests.
     mochaOnError = window.onerror;
     window.onerror = function(err, url, line) {
       console.error(err, url, line);
     };
     window.addEventListener('message', (event) => {
       if (event.data == 'unittest-suite-done') {
         window.console.log("Done running unittests");
@@ skipping 21 matching lines @@
 
     for (let action of unittest_tests) {
       try {
         action();
       } catch (e) {
         console.error("Caught error tying to setup test:", e);
       }
     }
   });
 });