Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2345853002: Restore unittests (Closed)

Created:
4 years, 3 months ago by vsm
Modified:
4 years, 2 months ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M pkg/dev_compiler/test/browser/language_tests.js View 4 chunks +16 lines, -8 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
vsm
4 years, 3 months ago (2016-09-15 22:49:32 UTC) #3
Jennifer Messerly
LGTM!
4 years, 3 months ago (2016-09-15 22:56:03 UTC) #4
Bob Nystrom
lgtm https://codereview.chromium.org/2345853002/diff/1/pkg/dev_compiler/test/browser/language_tests.js File pkg/dev_compiler/test/browser/language_tests.js (right): https://codereview.chromium.org/2345853002/diff/1/pkg/dev_compiler/test/browser/language_tests.js#newcode845 pkg/dev_compiler/test/browser/language_tests.js:845: if (unittest.src__test_environment.environment.testCases[dart_sdk.dartx.length] != 0) { Nit: long line.
4 years, 3 months ago (2016-09-16 17:04:35 UTC) #5
vsm
4 years, 2 months ago (2016-10-05 23:59:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ef973f7d56e2427310cd5bdb681b76c0f2611bfc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698