Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 234583008: Revert 263262 "Newly created profiles should have the grey silho..." (Closed)

Created:
6 years, 8 months ago by viettrungluu
Modified:
6 years, 8 months ago
Reviewers:
Mike Lerman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 263262 "Newly created profiles should have the grey silho..." Adds static initializers. See: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/63585 # profile_avatar_icon_util.cc profiles::kNoHighResAvatar # profile_avatar_icon_util.cc profiles::kDefaultAvatarIconResourceFileNames+0xd0 > Newly created profiles should have the grey silhouette as avatar. > The name should still be automatically generated. > > Also, all the avatar icons are becoming squares (31x38 -> 38x38). New resources will be committed and necessary code changes have been made. > > > BUG=337986 > TEST=When creating a new profile from anywhere except the settings. Also, verify avatar icons are still rendered correctly, whether GAIA, the placeholder or a cartoon icon. > page, the automatically assigned avatar should the grey > placeholder (silhouette). > > Review URL: https://codereview.chromium.org/212603011 TBR=mlerman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -102 lines) Patch
M trunk/src/build/ios/grit_whitelist.txt View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/app/theme/chrome_unscaled_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/app/theme/theme_resources.grd View 4 chunks +4 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_avatar_icon_util.h View 2 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_avatar_icon_util.cc View 8 chunks +13 lines, -39 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_info_cache.cc View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_metrics.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_shortcut_manager_win.cc View 2 chunks +16 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_window.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/resources/options/browser_options.css View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/resources/options/manage_profile_overlay.css View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_view.h View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +4 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/taskbar_decorator_win.cc View 2 chunks +22 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/profiles/profile_chooser_view.cc View 2 chunks +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 8 months ago (2014-04-11 18:10:40 UTC) #1
viettrungluu
6 years, 8 months ago (2014-04-11 18:11:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r263284 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698