Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 234583005: Make sure that ranges are not accessed after range analysis. Remove HValue::PrintRangeTo. (Closed)

Created:
6 years, 8 months ago by Sven Panne
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Make sure that ranges are not accessed after range analysis. Remove HValue::PrintRangeTo. The ranges are simply wrong after range analysis, and we should only rely on computed flags. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20674

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M src/hydrogen-instructions.h View 4 chunks +17 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M src/hydrogen-range-analysis.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen-range-analysis.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 8 months ago (2014-04-11 09:13:45 UTC) #1
Benedikt Meurer
lgtm
6 years, 8 months ago (2014-04-11 09:14:25 UTC) #2
Sven Panne
6 years, 8 months ago (2014-04-11 09:17:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698