Add a command line switch --enable-consumer-management.

Add a command line switch --enable-consumer-management.

Add a security section and a consumer management enroll button in the settings
page and make it hidden behind the command line switch.

Rename the original security section in the settings page to "certificates", as
that is what it is.

BUG=353050
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264480

[davidyu, 2014-04-11 07:32:19]

Hi Dan,

I am adding a button in the settings page for the new feature. This change is
only 50~60% finished, but I'd like to add it to make the development easier. It
is hidden by default and can be enabled via a command line switch.

Mock is here:
https://drive.google.com/corp/drive/u/0/#folders/0Bx8t7jg8vATveEpHckVMY1AwQzA...

[davidyu, 2014-04-14 02:48:11]

cc bartfab@

[bartfab (slow), 2014-04-15 13:57:53]

lgtm

https://codereview.chromium.org/234583003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/234583003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1567: //
TODO(davidyu): implement.
Nit 1: Capitalize start of sentence: s/implement/Implement/
Nit 2: Reference a bug number.

https://codereview.chromium.org/234583003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1568: LOG(ERROR) <<
"Consumer management enrolling is not implemented.";
Nit: #include "base/logging.h"

[davidyu, 2014-04-16 02:03:47]

Hi Dan, can you please take a look? Thanks!

https://codereview.chromium.org/234583003/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/234583003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1567: //
TODO(davidyu): implement.
On 2014/04/15 13:57:54, bartfab wrote:
> Nit 1: Capitalize start of sentence: s/implement/Implement/
> Nit 2: Reference a bug number.

Done.

https://codereview.chromium.org/234583003/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1568: LOG(ERROR) <<
"Consumer management enrolling is not implemented.";
On 2014/04/15 13:57:54, bartfab wrote:
> Nit: #include "base/logging.h"

Removed LOG().

[Dan Beam, 2014-04-16 23:22:02]

lgtm, but can you mention what else this CL does (e.g. "adds a Security section
on ChromeOS that allows users to enroll their device to be wiped if they lose
it" or something like this...)

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1567: //
TODO(davidyu): Implement. crbug.com/353050.
nit: add http:// to link

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.h (right):

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.h:287: void
EnrollConsumerManagement(const base::ListValue* args);
nit: HandleEnrollConsumerManagement

https://codereview.chromium.org/234583003/diff/40001/chromeos/chromeos_switch...
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/234583003/diff/40001/chromeos/chromeos_switch...
chromeos/chromeos_switches.cc:68: // Enables consumer management.
^ can you expand on this?  i.e. the functional affects or more generally what
this flag should control?

[davidyu, 2014-04-17 01:14:54]

I think I have described every change this CL does in the issue description. For
the overview of the consumer management service for Chrome OS, our PRD is at
https://docs.google.com/a/google.com/document/d/1sDbUgkEWxyTjJRN70FOpQnvWAFVd...

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.cc:1567: //
TODO(davidyu): Implement. crbug.com/353050.
On 2014/04/16 23:22:03, Dan Beam wrote:
> nit: add http:// to link

Done.

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/browser_options_handler.h (right):

https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/browser_options_handler.h:287: void
EnrollConsumerManagement(const base::ListValue* args);
On 2014/04/16 23:22:03, Dan Beam wrote:
> nit: HandleEnrollConsumerManagement

Done.

https://codereview.chromium.org/234583003/diff/40001/chromeos/chromeos_switch...
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/234583003/diff/40001/chromeos/chromeos_switch...
chromeos/chromeos_switches.cc:68: // Enables consumer management.
On 2014/04/16 23:22:03, Dan Beam wrote:
> ^ can you expand on this?  i.e. the functional affects or more generally what
> this flag should control?

Done.

[Dan Beam, 2014-04-17 01:29:21]

On 2014/04/17 01:14:54, davidyu wrote:
> I think I have described every change this CL does in the issue description.

yeah, sorry, re-read it.  seems fine.  slgtm

> For
> the overview of the consumer management service for Chrome OS, our PRD is at
>
https://docs.google.com/a/google.com/document/d/1sDbUgkEWxyTjJRN70FOpQnvWAFVd...
> 
>
https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
> File chrome/browser/ui/webui/options/browser_options_handler.cc (right):
> 
>
https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
> chrome/browser/ui/webui/options/browser_options_handler.cc:1567: //
> TODO(davidyu): Implement. crbug.com/353050.
> On 2014/04/16 23:22:03, Dan Beam wrote:
> > nit: add http:// to link
> 
> Done.
> 
>
https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
> File chrome/browser/ui/webui/options/browser_options_handler.h (right):
> 
>
https://codereview.chromium.org/234583003/diff/40001/chrome/browser/ui/webui/...
> chrome/browser/ui/webui/options/browser_options_handler.h:287: void
> EnrollConsumerManagement(const base::ListValue* args);
> On 2014/04/16 23:22:03, Dan Beam wrote:
> > nit: HandleEnrollConsumerManagement
> 
> Done.
> 
>
https://codereview.chromium.org/234583003/diff/40001/chromeos/chromeos_switch...
> File chromeos/chromeos_switches.cc (right):
> 
>
https://codereview.chromium.org/234583003/diff/40001/chromeos/chromeos_switch...
> chromeos/chromeos_switches.cc:68: // Enables consumer management.
> On 2014/04/16 23:22:03, Dan Beam wrote:
> > ^ can you expand on this?  i.e. the functional affects or more generally
what
> > this flag should control?
> 
> Done.

[davidyu, 2014-04-17 01:38:57]

Hi Nikita,

Can you help reviewing chrome/browser/chromeos/login/chrome_restart_request.cc?
Thanks!

[Nikita (slow), 2014-04-17 04:51:19]

lgtm

[davidyu, 2014-04-17 04:54:50]

The CQ bit was checked by davidyu@chromium.org

[commit-bot: I haz the power, 2014-04-17 04:55:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davidyu@chromium.org/234583003/60001

[commit-bot: I haz the power, 2014-04-17 12:25:15]

Change committed as 264480