Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1090)

Issue 2345813002: Query native channel count in preferred parameters. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
watk
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Query native channel count in preferred parameters. w/o this, WebAudio will always think there are only two channels available. Untested since I don't have a 5.1 setup on Linux. BUG=646435 TEST=verified that 2 channels are reported locally. Committed: https://crrev.com/19c6a0755a478b6d759a98e1f12adfac8a6a6cfb Cr-Commit-Position: refs/heads/master@{#419052}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M media/audio/pulse/audio_manager_pulse.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 5 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
DaleCurtis
4 years, 3 months ago (2016-09-15 21:08:09 UTC) #2
watk
lgtm https://codereview.chromium.org/2345813002/diff/1/media/audio/pulse/audio_manager_pulse.h File media/audio/pulse/audio_manager_pulse.h (right): https://codereview.chromium.org/2345813002/diff/1/media/audio/pulse/audio_manager_pulse.h#newcode75 media/audio/pulse/audio_manager_pulse.h:75: // GetNativeSampleRate(). comment is out of date
4 years, 3 months ago (2016-09-15 21:21:52 UTC) #4
DaleCurtis
https://codereview.chromium.org/2345813002/diff/1/media/audio/pulse/audio_manager_pulse.h File media/audio/pulse/audio_manager_pulse.h (right): https://codereview.chromium.org/2345813002/diff/1/media/audio/pulse/audio_manager_pulse.h#newcode75 media/audio/pulse/audio_manager_pulse.h:75: // GetNativeSampleRate(). On 2016/09/15 at 21:21:52, watk wrote: > ...
4 years, 3 months ago (2016-09-15 21:35:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2345813002/20001
4 years, 3 months ago (2016-09-15 21:36:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-16 00:27:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 00:31:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/19c6a0755a478b6d759a98e1f12adfac8a6a6cfb
Cr-Commit-Position: refs/heads/master@{#419052}

Powered by Google App Engine
This is Rietveld 408576698