Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 23458035: UMA stats instrumentation for Renderer.AcceleratedFixedRootBackground (Closed)

Created:
7 years, 3 months ago by Ian Vollick
Modified:
7 years, 3 months ago
CC:
blink-reviews, blink-layers+watch_chromium.org, dglazkov+blink, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Visibility:
Public.

Description

UMA stats instrumentation for Renderer.AcceleratedFixedRootBackground Along with http://crrev.com/23983017, this adds and makes use of Renderer.AcceleratedFixedRootBackground UMA histogram. Records three counts: 1. The total number of main frame scrolls. 2. The total number of main frame scrolls with an accelerated fixed root background. 3. The total number of main frame scrolls with an unaccelerated fixed root background. R=hartmanng@chromium.org,asvitkine@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157457

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M Source/core/rendering/RenderLayerCompositor.cpp View 2 chunks +21 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
Ian Vollick
7 years, 3 months ago (2013-09-09 14:22:57 UTC) #1
hartmanng
https://codereview.chromium.org/23458035/diff/1/Source/core/rendering/RenderLayerCompositor.cpp File Source/core/rendering/RenderLayerCompositor.cpp (right): https://codereview.chromium.org/23458035/diff/1/Source/core/rendering/RenderLayerCompositor.cpp#newcode1232 Source/core/rendering/RenderLayerCompositor.cpp:1232: if (!m_renderView->rootBackgroundIsEntirelyFixed()) I remember you mentioned that pages can ...
7 years, 3 months ago (2013-09-09 14:31:26 UTC) #2
Ian Vollick
On 2013/09/09 14:31:26, hartmanng wrote: > https://codereview.chromium.org/23458035/diff/1/Source/core/rendering/RenderLayerCompositor.cpp > File Source/core/rendering/RenderLayerCompositor.cpp (right): > > https://codereview.chromium.org/23458035/diff/1/Source/core/rendering/RenderLayerCompositor.cpp#newcode1232 > ...
7 years, 3 months ago (2013-09-09 14:35:37 UTC) #3
hartmanng
lgtm
7 years, 3 months ago (2013-09-09 14:39:15 UTC) #4
Alexei Svitkine (slow)
lgtm
7 years, 3 months ago (2013-09-09 14:40:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/23458035/1
7 years, 3 months ago (2013-09-09 14:46:06 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 15:54:14 UTC) #7
Message was sent while issue was closed.
Change committed as 157457

Powered by Google App Engine
This is Rietveld 408576698