Issue 23458032: Handle view-source: URLs better in the history providers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23458032: Handle view-source: URLs better in the history providers. (Closed)

Created:
7 years, 3 months ago by Peter Kasting

Modified:
7 years, 3 months ago

Reviewers:
beaudoin

CC:
chromium-reviews, James Su

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Handle view-source: URLs better in the history providers. This makes fixup strip the "http://" scheme back out when the user didn't type it, even when it was inserted after "view-source:". This also fixes highlighting of such input in the resulting matches. BUG=286451 TEST=Typing "view-source:x" doesn't crash, and highlights correctly in the dropdown R=beaudoin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222097

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -19 lines)			Patch
M	chrome/browser/autocomplete/history_provider.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View	2 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

Philippe, I know you're not the ideal reviewer for this, but mpearson is on paternity ...

7 years, 3 months ago (2013-09-06 22:38:42 UTC) #1

Peter Kasting

7 years, 3 months ago (2013-09-09 21:29:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r222097 (presubmit successful).

Expand Messages | Collapse Messages