Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: trunk/src/chrome/browser/signin/profile_oauth2_token_service.cc

Issue 23458028: Revert 221035 "Revert 219146 "[sync] Force re-auth during sync s..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/signin/profile_oauth2_token_service.cc
===================================================================
--- trunk/src/chrome/browser/signin/profile_oauth2_token_service.cc (revision 221737)
+++ trunk/src/chrome/browser/signin/profile_oauth2_token_service.cc (working copy)
@@ -155,6 +155,15 @@
break;
}
case chrome::NOTIFICATION_TOKEN_LOADING_FINISHED:
+ // During startup, if the user is signed in and the OAuth2 refresh token
+ // is empty, flag it as an error by badging the menu. Otherwise, if the
+ // user goes on to set up sync, they will have to make two attempts:
+ // One to surface the OAuth2 error, and a second one after signing in.
+ // See crbug.com/276650.
+ if (!GetAccountId(profile_).empty() && GetRefreshToken().empty()) {
+ UpdateAuthError(GoogleServiceAuthError(
+ GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
+ }
FireRefreshTokensLoaded();
break;
default:
« no previous file with comments | « no previous file | trunk/src/chrome/browser/ui/sync/one_click_signin_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698