src/platform-posix.cc - Issue 23458022: Use PAGE_NOACCESS for guard pages in Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/platform-posix.cc

Issue 23458022: Use PAGE_NOACCESS for guard pages in Windows. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/platform-posix.cc

diff --git a/src/platform-posix.cc b/src/platform-posix.cc

index 504d140138c178fe50ff19480e20dcefd3db3a99..b111213f6d61783e217293061fa9d309a8206181 100644

--- a/src/platform-posix.cc

+++ b/src/platform-posix.cc

@@ -152,7 +152,7 @@ void OS::ProtectCode(void* address, const size_t size) {

void OS::Guard(void* address, const size_t size) {

#if defined(__CYGWIN__)

DWORD oldprotect;

- VirtualProtect(address, size, PAGE_READONLY | PAGE_GUARD, &oldprotect);

+ VirtualProtect(address, size, PAGE_NOACCESS, &oldprotect);

#else

mprotect(address, size, PROT_NONE);

#endif

« no previous file with comments | « src/platform-cygwin.cc ('k') | src/platform-win32.cc » ('j') | no next file with comments »