[NaCl SDK] Screen capture extension for use with SDK visual testing.

[NaCl SDK] Screen capture extension for use with SDK visual testing.

BUG=none
R=sbc@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221777

[Sam Clegg, 2013-09-05 00:05:31]

lgtm

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/screenshot_extension/injected.js (right):

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/screenshot_extension/injected.js:50: if
(event.data.target !== 'background')
There seems to be mismatch between the commend and code here?

"Ignore messages not destined for the background page?"

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/screenshot_extension/screenshot.js
(right):

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/screenshot_extension/screenshot.js:10: *
background page injects screen code into this page */
Be consistent with javadoc style comments here.  The style I'm most
used to (and the one I think we are using most in the SDK) is:

/** single line */

/**
 * multi line
 */

[binji, 2013-09-06 20:59:48]

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/screenshot_extension/injected.js (right):

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/screenshot_extension/injected.js:50: if
(event.data.target !== 'background')
On 2013/09/05 00:05:31, Sam Clegg wrote:
> There seems to be mismatch between the commend and code here?
> 
> "Ignore messages not destined for the background page?"

Done.

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/screenshot_extension/screenshot.js
(right):

https://codereview.chromium.org/23458018/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/screenshot_extension/screenshot.js:10: *
background page injects screen code into this page */
On 2013/09/05 00:05:31, Sam Clegg wrote:
> Be consistent with javadoc style comments here.  The style I'm most
> used to (and the one I think we are using most in the SDK) is:
> 
> /** single line */
> 
> /**
>  * multi line
>  */
> 
>   

Done.

[binji, 2013-09-06 21:00:33]

Committed patchset #2 manually as r221777 (presubmit successful).